Fix data not being required during invocation with a schema+reference
#463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eb8d1ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
IGassmann
approved these changes
Jan 15, 2024
Merged
jpwilliams
pushed a commit
that referenced
this pull request
Jan 17, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## inngest@3.11.0 ### Minor Changes - [#467](#467) [`ca93ef8`](ca93ef8) Thanks [@tonyhb](https://github.com/tonyhb)! - Add timeouts to debounce configuration ### Patch Changes - [#463](#463) [`61562bd`](61562bd) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix `data` not being required during invocation with a schema+reference - [#462](#462) [`c449efe`](c449efe) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix not allowing a single-element `concurrency` option in function definitions - [#466](#466) [`ecde5b6`](ecde5b6) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix some out-of-date comments and examples Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using
referenceFunction()to invoke,datawas never required, even if the referenced function had adataschema.This call should (and does following this PR) throw a TS error as it is lacking
data:Checklist
Added a docs PR that references this PRN/A Bug fix