Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic function invocation event to all event schemas #489

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

jpwilliams
Copy link
Member

@jpwilliams jpwilliams commented Feb 15, 2024

Summary

Fixes an issue where inngest/function.invoked was missing from the list of internal events automatically returned when using GetEvents<typeof inngest, true>.

Also slightly refactors how these internal events are added, ensuring we can't forget them again.

Checklist

  • Added a docs PR that references this PR N/A Bug fix
  • Added unit/integration tests
  • Added changesets if applicable

@jpwilliams jpwilliams added the Bug Something isn't working label Feb 15, 2024
@jpwilliams jpwilliams self-assigned this Feb 15, 2024
Copy link

changeset-bot bot commented Feb 15, 2024

🦋 Changeset detected

Latest commit: cd2133f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
inngest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@inngest-release-bot inngest-release-bot added the 📦 inngest Affects the `inngest` package label Feb 15, 2024
@jpwilliams jpwilliams merged commit 244b6bd into main Feb 19, 2024
35 checks passed
@jpwilliams jpwilliams deleted the fix/include-invocation-internal-event branch February 19, 2024 20:40
jpwilliams pushed a commit that referenced this pull request Feb 19, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## inngest@3.14.2

### Patch Changes

- [#492](#492)
[`ad67476`](ad67476)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix delayed
environment variables not using event key in `"inngest/cloudflare"`

- [#489](#489)
[`244b6bd`](244b6bd)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Add generic
function invocation event to all event schemas

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working 📦 inngest Affects the `inngest` package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants