New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INN-2882 Add selective header forwarding when sending events #520
Conversation
🦋 Changeset detectedLatest commit: 7ed02b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A user has added the prerelease/inngest label, so this PR will be published to npm with the tag You can install this prerelease version with: npm install inngest@pr-520 The last release was built and published from 7ed02b4. |
## Summary <!-- Succinctly describe your change, providing context, what you've changed, and why. --> Fixes integration tests returning an incorrect ID when sending events. ## Checklist <!-- Tick these items off as you progress. --> <!-- If an item isn't applicable, ideally please strikeout the item by wrapping it in "~~"" and suffix it with "N/A My reason for skipping this." --> <!-- e.g. "- [ ] ~~Added tests~~ N/A Only touches docs" --> - [ ] ~Added a [docs PR](https://github.com/inngest/website) that references this PR~ N/A - [x] Added unit/integration tests - [x] Added changesets if applicable ## Related <!-- A space for any related links, issues, or PRs. --> <!-- Linear issues are autolinked. --> <!-- e.g. - INN-123 --> <!-- GitHub issues/PRs can be linked using shorthand. --> <!-- e.g. "- inngest/inngest#123" --> <!-- Feel free to remove this section if there are no applicable related links.--> - INN-2879 - inngest/inngest#1238 - Unblocks: - #518 - #519 - #520 - #521
@jpwilliams anything still waiting on? |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## inngest@3.18.1 ### Patch Changes - [#520](#520) [`0703740`](0703740) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Add selective header forwarding when sending events, allowing context propagation when tracing fanouts 👀 - [#549](#549) [`f759de1`](f759de1) Thanks [@maktouch](https://github.com/maktouch)! - Add step name or ID when there’s a NESTING_STEPS error Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Summary
Read the incoming headers tracestate and traceparent. If it is set, copy the header to any outgoing event-sending requests.
This only covers
step.sendEvent()
; we'll add later support forclient.send()
as we need async hooks for this which has scattered runtime support.Checklist
Added a docs PR that references this PRN/ARelated