INN-2911: Fix empty event payloads in UI due to resolver bug #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djfarrelly
requested review from
tonyhb,
darwin67,
goodoldneon and
jpwilliams
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
djfarrelly
commented
Apr 3, 2024
Comment on lines
-93
to
-95
| // Runner.Events maps events by an event ID that could be either the | ||
| // internal or external ID. It'll be the internal ID if the event didn't | ||
| // have an external ID |
There was a problem hiding this comment.
As of this change, I believe this comment is no longer true: https://github.com/inngest/inngest/pull/1238/files#diff-52e41636f29e1f855e51f1ad1144dd1cc18e411574f06628ddc711f2564130d5R118 cc @jpwilliams for confirmation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change introduced in #1238 changed how IDs are used (diff) within the
runnerservice. This invalidated the previous fix in #1201.This issue happens as sometimes two different event ids are created for a single event which is another, separate issue. This is reproducible by using the Invoke or Sent event button via the UI, but doesn't happen when sending an event via curl. The fix in this PR makes this issue separate and not a problem.
Tested:
Motivation
This looks like there was a valid bug fix with #1201 then #1238 caused a regression due to a change in how IDs are handled.
Type of change (choose one)
Checklist
Check our Pull Request Guidelines