INN 3054 add filter by function slug #1370
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cannot be merged before the API: https://github.com/inngest/monorepo/pull/2705MergedFilter the runs by function slug - this wasn't available initially in the API, so we were fetching all the runs from all the functions in the page.
Motivation
Our frontend isn't using functionID as the param on function runs pages, but the functionSlug instead. Given the structure of our layout pages, it's easier to move the logic to the API rather than query and calculate the IDs.
Type of change (choose one)
Checklist
Check our Pull Request Guidelines