Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INN 3054 add filter by function slug #1370

Merged
merged 3 commits into from
May 20, 2024

Conversation

anafilipadealmeida
Copy link
Contributor

@anafilipadealmeida anafilipadealmeida commented May 17, 2024

Description

Cannot be merged before the API: https://github.com/inngest/monorepo/pull/2705 Merged
Filter the runs by function slug - this wasn't available initially in the API, so we were fetching all the runs from all the functions in the page.

Screenshot 2024-05-17 at 22 02 31 Screenshot 2024-05-17 at 22 03 18

Motivation

Our frontend isn't using functionID as the param on function runs pages, but the functionSlug instead. Given the structure of our layout pages, it's easier to move the logic to the API rather than query and calculate the IDs.

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Check our Pull Request Guidelines

Copy link

linear bot commented May 17, 2024

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 10:21pm

@anafilipadealmeida anafilipadealmeida changed the title Ana/inn 3054 add filter by function INN 3054 add filter by function May 17, 2024
@anafilipadealmeida anafilipadealmeida changed the title INN 3054 add filter by function INN 3054 add filter by function slug May 17, 2024
@anafilipadealmeida anafilipadealmeida merged commit e6b185d into main May 20, 2024
7 checks passed
@anafilipadealmeida anafilipadealmeida deleted the ana/inn-3054-add-filter-by-function branch May 20, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants