-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The "File-Set Identification" module's information entity is not parsed correctly #37
Comments
There actually isn't an "Information Entity" column in these tables: http://dicom.nema.org/dicom/2013/output/chtml/part03/sect_F.3.html Compared to all the other tables: http://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_A.75.3.html |
Ahh, I see! It almost seems like the "Basic Directory" IOD doesn't belong on the page, since it is just an IOD and is not a CIOD like the other top-level nodes on the page. |
Should I remove it then? This was added because an issue mentioned that there were missing attributes/tags (that appear to only exist in this IOD) |
Ahh, I see---that makes sense. As we have done in other places, I don't think perfect consistency is necessary. I think we should remove the "- null" from the modules, but otherwise keep as is. What do you think? |
That makes sense to me. |
Update: Instead of just removing the "- null", we can use the IOD name as the "information entity" since "Basic Directory" is a single IOD rather than a CIOD. |
Bug description
The "File-Set Identification" module's information entity is not parsed correctly.
Steps for reproduction
Visit:
https://dicom.innolitics.com/ciods/basic-directory/file-set-identification
Expected behavior
The module's information entity would be present, instead of the string "null."
Additional context (e.g. screenshots)
The text was updated successfully, but these errors were encountered: