Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "File-Set Identification" module's information entity is not parsed correctly #37

Closed
johndgiese opened this issue May 18, 2020 · 6 comments · Fixed by #40
Closed
Assignees
Labels

Comments

@johndgiese
Copy link
Contributor

Bug description

The "File-Set Identification" module's information entity is not parsed correctly.

Steps for reproduction

Visit:

https://dicom.innolitics.com/ciods/basic-directory/file-set-identification

Expected behavior

The module's information entity would be present, instead of the string "null."

Additional context (e.g. screenshots)

Screen Shot 2020-05-18 at 4 48 36 PM

@johndgiese johndgiese added bug browser Pertains to the DICOM Standard Browser and removed browser Pertains to the DICOM Standard Browser labels May 18, 2020
@russellkan
Copy link
Contributor

russellkan commented May 18, 2020

There actually isn't an "Information Entity" column in these tables: http://dicom.nema.org/dicom/2013/output/chtml/part03/sect_F.3.html
image

Compared to all the other tables: http://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_A.75.3.html
image

@johndgiese
Copy link
Contributor Author

Ahh, I see! It almost seems like the "Basic Directory" IOD doesn't belong on the page, since it is just an IOD and is not a CIOD like the other top-level nodes on the page.

@russellkan
Copy link
Contributor

Should I remove it then? This was added because an issue mentioned that there were missing attributes/tags (that appear to only exist in this IOD)

@johndgiese
Copy link
Contributor Author

Ahh, I see---that makes sense. As we have done in other places, I don't think perfect consistency is necessary. I think we should remove the "- null" from the modules, but otherwise keep as is. What do you think?

@russellkan
Copy link
Contributor

That makes sense to me.

@russellkan russellkan self-assigned this May 19, 2020
@russellkan
Copy link
Contributor

Update: Instead of just removing the "- null", we can use the IOD name as the "information entity" since "Basic Directory" is a single IOD rather than a CIOD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants