expand childpages if converted to pandoc

[sHermanGriffiths]

Author's Checklist

Before assigning reviewers, step through the following checklist. Check each item once it's completed. If an item is skipped, write an explanation below the item.

• Construction: Review the code diff and confirm there's no dead code, debug code, or unnecessary comments.
• Requirements: Review the requirements in the issue for this PR and confirm they're all implemented.
• Architecture: Confirm that the changes to the code are consistent with the existing architecture.
• SOUP/OTS Software: Any new dependencies have appropriate licenses and are documented or pinned in requirements files.
• Unit Test: Atomic unit tests have been added, if appropriate.
  N/A
• End-to-End Tests: End-to-end tests have been extended or updated, if appropriate.
  N/A
• Low-level Documentation: Comments or doc strings for affected code have been updated.
  N/A
• High-Level Documentation: The README is updated, as appropriate.
  N/A
• Change Log: New features or bug fixes have been added to the change log in the README.
  N/A

[johndgiese]

Nice idea! I think it makes a lot of sense to expand out sub pages. I would actually not show the page title as an H1, and would just show the page's content in place. This would work identically to linked pages then, which we use (or have a plugin) that expands.

[sHermanGriffiths]

yea, I only did it as a debug because this subpage was converting to pandoc as a Pandoc block inside of another Pandoc block and that's against protocol. Is there another way you'd solve that?

[johndgiese]

I think this was due to a weird thing Emily did in the templates. I just fixed it in the templates! That said, I think expanding the page (without the title) is a good idea.

[bimbashrestha]

Could we just add a condition to the if statement on Line 77 below rather than having a separate elif for this?

if isinstance(result, list) or block_type == ChildPageBlock:

I think we'd still get the desired functionality right (double check this please)?

[sHermanGriffiths]

It's not the same because ChildPageBlock.to_pandoc() results in a Pandoc block which will cause an error because all of the pandoc will eventually end up in another Pandoc block. that's why result[1] is selected on line 73. I could bring this logic down into that iteration though

[bimbashrestha]

Nice work @sHermanGriffiths!