Notion refactor #150
Merged
Notion refactor #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
N2Y wraps a lot of methods in the
retry_api_callunnecessarily due to poor architecture. I've fixed this by running all API calls through_[request_method]_urlmethods so that the only methods that need to be wrapped are those. I've also commented out un-shared synced block warnings (as David requested during our weekly check-in) and protected against infinite recursion when handling synced blocks (this bug is explained here in a short video).How Did You Test It
I ensured that I was able to properly export the Prenuvo page where this error was occurring, then made sure that the code base still passed all tests.