Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass pandoc options to properties and rich text arrays #169

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

sHermanGriffiths
Copy link
Contributor

@sHermanGriffiths sHermanGriffiths commented Feb 1, 2024

Describe Your Changes

Make the necessary changes to pass each export's pandoc_options settings to wherever pandoc.write is called for consistency in the exports. Also, this could reasonably be the expected behavior. Also updated the readme and version number.

How Did You Test It

I updated the tests to pass pandoc_options wherever necessary.

n2y/rich_text.py Outdated
@@ -211,11 +211,12 @@ def __getitem__(self, index):
def to_pandoc(self):
return sum([item.to_pandoc() for item in self.items], [])

def to_value(self, pandoc_format):
def to_value(self, pandoc_format, pandoc_options):
print(self.client.export_defaults)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor

@johndgiese johndgiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! See the one comment I had about the print statement. Please push the version to pypi and update the PR on the website to use this.

@sHermanGriffiths sHermanGriffiths deleted the shg/options branch February 1, 2024 19:17
@sHermanGriffiths sHermanGriffiths restored the shg/options branch February 1, 2024 19:18
@sHermanGriffiths sHermanGriffiths merged commit a77d752 into main Feb 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants