Expand caching #75
Closed
Expand caching #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a draft solution to the assignment. Comments are intended for author and reviewer. There are several loose ends, or undeveloped blocks.
End of line characters removed per flake8
The `Page.children` property was not recursing into child blocks and as a result any child database or page that was not a top-level block would be picked up by the audit system. This bug would affect other things too, although it was noticed due to an audit producing false positives.
Mentions in simple tables were showing up as "Untitled". I found a workaround that should suffice for now. I will also point Notion to the test.
This is important as we're soon going to be using link to page blocks in an upcoming plugin.
Previosuly, the id and url properties were only available when dumping to YAML files. There are valid use cases when these properties should be added to markdown front matter YAML too. This commit makes them apply to both.
- The two unit tests will be fixed later - Remove a spurious assertion that was added to the all blocks test - Remove a dead end to end test
- Simplify notion_mocks.py method mock_page - Various stylistic changes
Link to page block
Note that this is just some example code. The cache class hasn't been implemented yet and it hasn't been tested. Also, as written it will be hard to handle the case when there is no cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.