Children #81
Merged
Children #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johndgiese
reviewed
Sep 24, 2022
tests/test_children.py
Outdated
|
|
||
|
|
||
| def test_create_and_delete_blocks(): | ||
| url = "https://www.notion.so/innolitics/Test-Page-46bc615bed5a479e8390d9373279426f" |
There was a problem hiding this comment.
We should use the same notion pages and access token we use for the end to end tests here. See the doc string at the top of tests/end_to_end_tests.py
johndgiese
reviewed
Sep 24, 2022
johndgiese
reviewed
Sep 24, 2022
johndgiese
requested changes
Sep 24, 2022
johndgiese
reviewed
Sep 26, 2022
n2y/notion.py
Outdated
| headers = {**self.headers} | ||
| del headers['Content-Type'] | ||
| response = requests.delete( | ||
| f"{self.base_url}blocks/{block_id}", headers=self.headers |
There was a problem hiding this comment.
This line should use headers, not self.headers.
johndgiese
reviewed
Sep 26, 2022
johndgiese
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.