Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emoji support #84

Merged
merged 4 commits into from
Oct 4, 2022
Merged

Emoji support #84

merged 4 commits into from
Oct 4, 2022

Conversation

johndgiese
Copy link
Contributor

No description provided.

@johndgiese
Add support for emojis
3d2eadd
@johndgiese
Small logger update
bf77c74
@johndgiese
Small improvements to error messages
ebeb785 
- Provide a link back to the database that you don't have permission to
- Suggest switching nested databases into a simple table
@johndgiese johndgiese marked this pull request as ready for review October 4, 2022 14:49
johndgiese
johndgiese commented Oct 4, 2022
View reviewed changes
n2y/main.py Show resolved Hide resolved
bimbashrestha
bimbashrestha approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@bimbashrestha bimbashrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it won't take long, maybe we can add an emoji to our end to end tests?

Feel free to merge without though.

n2y/blocks.py Show resolved Hide resolved
n2y/emoji.py Show resolved Hide resolved
@johndgiese
Copy link
Contributor Author

@bimbashrestha I looked into testing this, but it would take some effort to test mainly because the end-to-end tests don't have access to the Page objects and the page.icon isn't used at all in the exports. Thus, to test the emoji we would need to create an end-to-end test that worked lower level or we would need to create a plugin to extract out the emoji. I do have one page in the end-to-end tests that has an emoji, which ensures it won't crash if there is an emoji :)

I'm going to merge.

@johndgiese johndgiese merged commit ba1b96a into config-revamp Oct 4, 2022
@johndgiese johndgiese deleted the emoji-support branch October 4, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bimbashrestha bimbashrestha bimbashrestha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johndgiese @bimbashrestha