update how database filters children and add version flag #89
Conversation
README.md
Outdated
| @@ -330,7 +330,17 @@ Here are some features we're planning to add in the future: | |||
|
|
|||
| ## Changelog | |||
|
|
|||
| ### v0.6.4 | |||
There was a problem hiding this comment.
It looks like the version is repeated. Also, please format the bug fix in a consistent manner with previous bug fixes.
| help="Level to set the root logging module to", | ||
| ) | ||
| parser.add_argument( |
There was a problem hiding this comment.
I'd try to pull the version number out of setup.py somehow, so we don't have to update it in two places (we'll probably forget if we have to).
n2y/database.py
Outdated
| if self._children is None: | ||
| self._children = self.client.get_database_pages(self.notion_id, filter, sort) | ||
| return self._children | ||
| if not filter: |
There was a problem hiding this comment.
What was the motivation for these changes?
There was a problem hiding this comment.
If the database is pulled from the cache and a filter has already been run on it, but you want it to run a different filter it won't. Thus, documents/510k was just giving me the same results as documents/dhf.
There was a problem hiding this comment.
Can we add an intermediate variable like loading_from_cache = filter != None or something similar to capture why we're branching?
sHermanGriffiths
requested review from
johndgiese and
bimbashrestha
and removed request for
johndgiese
- add `get_children()` method to databases and pages in order to update `Database._children` and `Page._children` manually - add `Client.copy_notion_database_children()` which allows users to copy a list of children (pages) into another database - correct `Client.append_child_notion_blocks()` (it now copies database children the appended child_databases)
| if tupled_filter not in self._filtered_children: | ||
| self._filtered_children[tupled_filter] = {} | ||
| if tupled_sort not in self._filtered_children[tupled_filter]: | ||
| self._filtered_children[tupled_filter][tupled_sort] = \ |
There was a problem hiding this comment.
Nit: you can avoid the \ by formatting it this way
self._filtered_children[tupled_filter][tupled_sort] = self.client.get_database_pages(
self.notion_id, filter, sort
)
There was a problem hiding this comment.
I did that for flake8, I tried your suggestion first but it would make the line 101 characters
| @@ -27,6 +28,10 @@ def main(raw_args, access_token): | |||
| "--verbosity", '-v', default='INFO', | |||
| help="Level to set the root logging module to", | |||
| ) | |||
| parser.add_argument( | |||
| "--version", action='version', version=pkg_resources.require("n2y")[0].version, | |||
There was a problem hiding this comment.
yay! thanks for adding this
n2y/notion.py
Outdated
| { | ||
| key: value | ||
| for (key, value) in child.items() | ||
| if key not in [ |
There was a problem hiding this comment.
Let's extract out this array into a variable at the top or a constant somewhere
Author's Checklist
Before assigning reviewers, step through the following checklist. Check each item once it's completed. If an item is skipped, write an explanation below the item.
N/A
N/A
N/A
N/A