Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter LineBreak class from table cells #93

Merged
merged 4 commits into from
Dec 16, 2022
Merged

filter LineBreak class from table cells #93

merged 4 commits into from
Dec 16, 2022

Conversation

sHermanGriffiths
Copy link
Contributor

@sHermanGriffiths sHermanGriffiths commented Dec 16, 2022

Author's Checklist

Before assigning reviewers, step through the following checklist. Check each item once it's completed. If an item is skipped, write an explanation below the item.

  • Construction: Review the code diff and confirm there's no dead code, debug code, or unnecessary comments.
  • Requirements: Review the requirements in the issue for this PR and confirm they're all implemented.
  • Architecture: Confirm that the changes to the code are consistent with the existing architecture.
  • SOUP/OTS Software: Any new dependencies have appropriate licenses and are documented or pinned in requirements files.
    N\A
  • Unit Test: Atomic unit tests have been added, if appropriate.
  • End-to-End Tests: End-to-end tests have been extended or updated, if appropriate.
    N\A
  • Low-level Documentation: Comments or doc strings for affected code have been updated.
    N\A
  • High-Level Documentation: The README is updated, as appropriate.
  • Change Log: New features or bug fixes have been added to the change log in the README.

@@ -201,11 +201,13 @@ def wrap_notion_file(self, notion_data):
def wrap_notion_emoji(self, notion_data):
return self.instantiate_class("emoji", None, self, notion_data)

def wrap_notion_rich_text_array(self, notion_data, block=None):
return self.instantiate_class("rich_text_array", None, self, notion_data, block)
def wrap_notion_rich_text_array(self, notion_data, block=None, table=None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like table is a boolean everywhere else. Should we set a default boolean value rather than None here? Same thing below.

@sHermanGriffiths sHermanGriffiths merged commit ac5df06 into main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants