-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't call onChange on Cancel event in checkbox component #37
Comments
riyalohia
added a commit
to riyalohia/design-system
that referenced
this issue
May 21, 2020
This one is fixed and will be included in the next version. |
riyalohia
added a commit
to riyalohia/design-system
that referenced
this issue
May 29, 2020
#39 Fixes this. |
stutirao
pushed a commit
to stutirao/design-system
that referenced
this issue
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
OnChange event should not be called when user presses cancel button in Dropdown(checkboxes)
Steps to reproduce
1.Open dropdown
2.Select/unselect and press cancel or simply press cancel
3.onChange event is called which is causing modal to popup
Expected result
Cancel should close the dropdown
Actual result
Cancel did not close the dropdown
The text was updated successfully, but these errors were encountered: