Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call onChange on Cancel event in checkbox component #37

Closed
im-vikram opened this issue May 19, 2020 · 2 comments
Closed

Don't call onChange on Cancel event in checkbox component #37

im-vikram opened this issue May 19, 2020 · 2 comments

Comments

@im-vikram
Copy link

Description

OnChange event should not be called when user presses cancel button in Dropdown(checkboxes)

Steps to reproduce

1.Open dropdown
2.Select/unselect and press cancel or simply press cancel
3.onChange event is called which is causing modal to popup

Expected result

Cancel should close the dropdown

Actual result

Cancel did not close the dropdown

riyalohia added a commit to riyalohia/design-system that referenced this issue May 21, 2020
@aditya-kumawat
Copy link
Contributor

This one is fixed and will be included in the next version.

riyalohia added a commit to riyalohia/design-system that referenced this issue May 29, 2020
@satyamyadav
Copy link
Collaborator

#39 Fixes this.
Story Link
Release: v1.0.0-9

stutirao pushed a commit to stutirao/design-system that referenced this issue Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants