Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes dropdown search design #39

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

riyalohia
Copy link
Contributor

@riyalohia riyalohia commented May 20, 2020

What does this implement/fix? Explain your changes.

  1. Fixes search design and adds clear button
  2. Fixes selected option color
  3. Adds parent Checkbox label (Select All) prop
  4. Fixes Cancel button event (Don't call onChange on Cancel event in checkbox component #37 )
  5. Adds button appearance prop

Does this close any currently open issues?

...

Any other comments?

...

Dependent PRs/Commits

...

Describe breaking changes, if any.

...

Checklist

Check all those that are applicable and complete.

  • Merged with latest master branch

@riyalohia riyalohia changed the title fix: fixes dropdown search design WIP: fixes dropdown search design May 20, 2020
@riyalohia riyalohia changed the title WIP: fixes dropdown search design fix: fixes dropdown search design May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants