Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(YouTube/Return YouTube Dislike): dislike count sometimes not shown in Shorts #1565

Closed
5 tasks done
jhon1282 opened this issue Oct 19, 2023 · 12 comments
Closed
5 tasks done

bug(YouTube/Return YouTube Dislike): dislike count sometimes not shown in Shorts #1565

jhon1282 opened this issue Oct 19, 2023 · 12 comments
Labels
Bug report Something isn't working

Comments

@jhon1282
Copy link

jhon1282 commented Oct 19, 2023 •
edited by inotia00
Loading

Type

Other

Tools used

Revancify

Application

YouTube v18.29.38~

Bug description

When you look at the shorts, the counting of the DISLIKE is not shown.

Steps to reproduce

  1. Patch YouTube v18.29.38+
  2. Play Shorts

Relevant log output

Na

Screenshots or videos

Screenshot_2023-10-19-13-17-52-746_app rvx android youtube

Solution

N/A

Additional context

N/A

Device Environment

Android 13
Miui 14

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • I have written the title and contents in English.
  • This issue does not reproduce on unpatched YouTube or YT Music.
@jhon1282 jhon1282 added the Bug report Something isn't working label Oct 19, 2023
@inotia00 inotia00 changed the title bug:RYD doesn't work in Sorths bug(YouTube/ReTurn Dislike): dislike count sometimes not shown in Shorts Oct 19, 2023
@inotia00
Copy link
Owner

inotia00 commented Oct 19, 2023 •
edited
Loading

It does not reproduce on my side
(Also doesn't reproduce on any device I have)

It may be an issue with the API server, or there may be other causes

Please try patching with YouTube v18.33.40 which uses the old style Shorts actionbar and let me know the result

@jhon1282
Copy link
Author

In 18.33.40 it works well
Screenshot_2023-10-19-14-03-54-853_app rvpx android youtube

@inotia00
Copy link
Owner

If so, it is a valid issue, even if it does not reproduce on my side

@jhon1282
Copy link
Author

jhon1282 commented Oct 19, 2023 •
edited
Loading

If it helps, I tried the latest version of the original ReVanced, just out of curiosity, and I have the same issue 🤔.
I assume it's a factor related to the new versions of YouTube.
Many thanks for your availability 🙏

@girshcatt
Copy link

If it helps, I tried the latest version of the original ReVanced, just out of curiosity, and I have the same issue 🤔. I assume it's a factor related to the new versions of YouTube. Many tanks for your availability 🙏

I can confirm it from my side and yes, it can be reproduced on ReVanced, you can create issue in ReVanced, i think that some of devs can have this issue and will reply you, just pin link on issue here and let inotia see when ReVanced will reply something

@jhon1282
Copy link
Author

https://github.com/Anarios/return-youtube-dislike
I don't know how it is implemented in the android application, but I see that they are making many bug fixes.

@inotia00 inotia00 changed the title bug(YouTube/ReTurn Dislike): dislike count sometimes not shown in Shorts bug(YouTube/Return YouTube Dislike): dislike count sometimes not shown in Shorts Oct 19, 2023
@inotia00
Copy link
Owner

In revanced-patches-v2.195.1, v18.33.40 was added to Spoof app version target

For those experiencing this issue, please spoof with v18.33.40

@inotia00 inotia00 mentioned this issue May 12, 2024
Closed
5 tasks
inotia00 added a commit to inotia00/revanced-integrations that referenced this issue May 14, 2024
@inotia00
fix(YouTube/Return YouTube Dislike): dislike count sometimes not show…
1d4d7e2 
…n in Shorts inotia00/ReVanced_Extended#1565
inotia00 added a commit to inotia00/revanced-patches that referenced this issue May 14, 2024
@inotia00
fix(YouTube/Return YouTube Dislike): dislike count sometimes not show…
a81ad3e 
…n in Shorts inotia00/ReVanced_Extended#1565
anddea pushed a commit to anddea/revanced-integrations that referenced this issue May 16, 2024
@inotia00 @anddea
fix(YouTube/Return YouTube Dislike): dislike count sometimes not show…
f869a37 
…n in Shorts inotia00/ReVanced_Extended#1565
anddea pushed a commit to anddea/revanced-integrations that referenced this issue May 16, 2024
@semantic-release-bot
chore(release): 0.152.0-dev.8 [skip ci]
b581d2d 
# [0.152.0-dev.8](v0.152.0-dev.7...v0.152.0-dev.8) (2024-05-16)

### Bug Fixes

* **YouTube Music/Hide ads:** `Hide fullscreen ads` setting also closes non-ad dialogs inotia00/ReVanced_Extended#1971 ([7dd292d](7dd292d))
* **YouTube/Description components:** crash occurs when the title of the engagement panel is null inotia00/ReVanced_Extended#2008 ([e4ba2d0](e4ba2d0))
* **YouTube/Hide layout components:** add method to hide settings with whitelist inotia00/ReVanced_Extended#1964 ([10e5d1a](10e5d1a))
* **YouTube/Return YouTube Dislike:** dislike count sometimes not shown in Shorts inotia00/ReVanced_Extended#1565 ([f869a37](f869a37))
* **YouTube/Return YouTube Dislike:** wrong video id is used in shorts inotia00/ReVanced_Extended#1987 ([3868c2b](3868c2b))
* **YouTube/Settings:** settings values of excluded patches have changed due to incorrect settings alignment ([d706d1b](d706d1b))
* **YouTube/SponsorBlock:** pressing the fine adjustment buttons skips to the end of the video while creating a new SponsorBlock segment inotia00/ReVanced_Extended#1980 ([f683045](f683045))
* **YouTube/Spoof format stream data:** check audio tags first ([75e84a2](75e84a2))
* **YouTube/Spoof format stream data:** incorrect url is used ([2f86f6b](2f86f6b))
* **YouTube/Video playback:** default video quality applies even when video is playing inotia00/ReVanced_Extended#1959 ([5cc2c04](5cc2c04))

### Features

* **YouTube/Spoof format stream data:** check endpoint url is non-null ([a25d7d7](a25d7d7))
* **YouTube/Spoof format stream data:** improve hook method, fetch to `ANDROID_TESTSUITE` client ([ef50cf5](ef50cf5))
* **YouTube:** Add `Hide videos by duration` and `Hide videos by views count` greater than specified value ([inotia00#37](https://github.com/anddea/revanced-integrations/issues/37)) ([d15028c](d15028c))
@Kuddus73
Copy link

Shouldn't this be closed as the latest release's log says that it is fixed?

@inotia00
Copy link
Owner

Ah, I missed one thanks anyway

@jhon1282
Copy link
Author

I apologize, but this issue is not fixed from my side.
I also changed devices but nothing changes.
Screenshot_2024-05-26-16-20-41-353_app rvx android youtube
patch_log.txt

@inotia00
Copy link
Owner

RYD will not work if you are not logged in to a Google account or are using Incognito mode
(Limitations of patch implementation)

The only workaround is to spoof with YouTube v18.33.40

@jhon1282
Copy link
Author

Ok, thank you very much.
RYD works fine for normal videos even if I don't log in with google account.
But not for shorts. This is really strange but that's how it is 😳

anddea pushed a commit to anddea/revanced-integrations that referenced this issue May 29, 2024
@semantic-release-bot
chore(release): 0.152.0 [skip ci]
ae6429e 
# [0.152.0](v0.151.0...v0.152.0) (2024-05-29)

### Bug Fixes

* App crashes when resource not found ([6abcabc](6abcabc))
* **YouTube - Append timestamp information:** Ensure correct RTL layout ([027b948](027b948))
* **YouTube - Default video quality:** Revert back ([d6da339](d6da339))
* **YouTube - Hide action buttons:** Some action buttons are not hidden properly ([c37f238](c37f238))
* **YouTube - Hide feed components:** `Hide mix playlists` setting hides components in channel profile ([dc151ae](dc151ae))
* **YouTube - Hide keyword content:** Filter Shorts found in horizontal shelves ([25465e2](25465e2))
* **YouTube - Hide Shorts components:** Channel headers were hidden if Shorts is disabled ([5451719](5451719))
* **YouTube - Hide Shorts components:** Exclude `Hide sound metadata label` and `Hide video link label` from `Hide info panel` ([a510788](a510788))
* **YouTube - Hide Shorts components:** Hide Shorts in search result horizontal shelves ([2be49fc](2be49fc))
* **YouTube - Return YouTube Dislike:** Disabling `Show dislikes in Shorts` disabled dislikes everywhere ([#11](#11)) ([1b317db](1b317db))
* **YouTube - Return YouTube Dislike:** Dislike counts showing in views ([83bf7b2](83bf7b2))
* **YouTube - Return YouTube Dislike:** Fix some issues ([281dbe3](281dbe3))
* **YouTube - Return YouTube Dislike:** Subscribe icon is hidden ([95b34d4](95b34d4))
* **YouTube - Searchbar:** Hide searchbar in RYD and Sponsorblock sections ([#13](#13)) ([ed60bea](ed60bea))
* **YouTube - Searchbar:** Prevent searchbar appearing briefly when switching between fragments ([#14](#14)) ([584e6e3](584e6e3))
* **YouTube - Searchbar:** Restore original settings page if query is empty ([#12](#12)) ([9592bd5](9592bd5))
* **YouTube - Shorts components:** Update pattern for hide disabled comments ([c7b2fd4](c7b2fd4))
* **YouTube - SponsorBlock:** `Submit a new segment` button did not work ([395d3ce](395d3ce))
* **YouTube - SponsorBlock:** Pressing Now while manually editing a segment results in an error ([9521baa](9521baa))
* **YouTube - Spoof format stream data:** Some Uris are not hooked ([7e49ab3](7e49ab3))
* **YouTube - Video playback:** Default video quality sometimes does not apply when video is not loaded ([86b8130](86b8130))
* **YouTube Music/Hide ads:** `Hide fullscreen ads` setting also closes non-ad dialogs inotia00/ReVanced_Extended#1971 ([7dd292d](7dd292d))
* **YouTube/Description components:** crash occurs when the title of the engagement panel is null inotia00/ReVanced_Extended#2008 ([e4ba2d0](e4ba2d0))
* **YouTube/Hide layout components:** add method to hide settings with whitelist inotia00/ReVanced_Extended#1964 ([10e5d1a](10e5d1a))
* **YouTube/Return YouTube Dislike:** dislike count sometimes not shown in Shorts inotia00/ReVanced_Extended#1565 ([f869a37](f869a37))
* **YouTube/Return YouTube Dislike:** wrong video id is used in shorts inotia00/ReVanced_Extended#1987 ([3868c2b](3868c2b))
* **YouTube/Settings:** settings values of excluded patches have changed due to incorrect settings alignment ([d706d1b](d706d1b))
* **YouTube/SponsorBlock:** pressing the fine adjustment buttons skips to the end of the video while creating a new SponsorBlock segment inotia00/ReVanced_Extended#1980 ([f683045](f683045))
* **YouTube/Spoof format stream data:** check audio tags first ([75e84a2](75e84a2))
* **YouTube/Spoof format stream data:** incorrect url is used ([2f86f6b](2f86f6b))
* **YouTube/Video playback:** default video quality applies even when video is playing inotia00/ReVanced_Extended#1959 ([5cc2c04](5cc2c04))
* **YouTube:** App crashes when `SponsorBlock` patch is excluded ([e657bbd](e657bbd))
* **YT Music - Hide terms container:** Patch doesn't require restart to apply the changes ([e987b6d](e987b6d))

### Features

* Refactor and match ReVanced and inotia ([30ad38a](30ad38a))
* **YouTube - Fullscreen components:** `Hide related videos in quick actions` setting has been merged into the `Hide related video overlay` setting ([a9b973b](a9b973b))
* **YouTube - Hide layout components:** Add `Hide videos based on duration` ([b6bd93a](b6bd93a))
* **YouTube - Hide layout components:** Add an option to hide videos with views greater than specified value ([14d4756](14d4756))
* **YouTube - Hide shorts components:** Add separate option to hide in player ([67cfeb8](67cfeb8))
* **YouTube - Hide shorts components:** Hide comments button if disabled or with label "0" ([44f3c2f](44f3c2f))
* **YouTube - Overlay buttons:** Add `Whitelist` overlay button ([564a044](564a044))
* **YouTube - Player components:** Add setting toggle for `Hide suggested video end screen` ([d020bc8](d020bc8))
* **YouTube - Settings:** Add ability to search in summaries and list entries ([fbe9e53](fbe9e53))
* **YouTube - Settings:** Add search bar for settings ([681cea9](681cea9))
* **YouTube - Toolbar components:** Remove `Hide trending searches` setting ([b14f20c](b14f20c))
* **YouTube Music - Player components:** Add `Enable black player background` setting ([d27d362](d27d362))
* **YouTube Music - Player components:** Add `Hide audio video switch toggle` setting ([68238da](68238da))
* **YouTube/Spoof format stream data:** check endpoint url is non-null ([a25d7d7](a25d7d7))
* **YouTube/Spoof format stream data:** improve hook method, fetch to `ANDROID_TESTSUITE` client ([ef50cf5](ef50cf5))
* **YouTube:** Add `Hide videos by duration` and `Hide videos by views count` greater than specified value ([inotia00#37](https://github.com/anddea/revanced-integrations/issues/37)) ([d15028c](d15028c))
* **YouTube:** Add `Spoof client` patch ([010f879](010f879))
* **YouTube:** Add support versions `19.19.39` - `19.20.34` ([3c4ccc3](3c4ccc3))
* **YouTube:** Hide live chat replay in fullscreen ([e8184a1](e8184a1))
* **YouTube:** Remove `Spoof test client` patch ([782b25b](782b25b))

### Reverts

* default landscape mode timeout ([f46db5d](f46db5d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@inotia00 @girshcatt @jhon1282 @Kuddus73