bug(YouTube Music/Hide ads): `Hide fullscreen ads` setting also closes non-ad dialogs #1971

soyDESKTOP68A2MRFT · 2024-05-09T16:46:47Z

Type

Error at runtime

Tools used

RVX Manager

Application

YT music 6.51.52

Bug description

When i try to create a playlist the create playlist dialog doesn't appear, and the playlist don't get created, it happens when i press save button and when i try to create it directly on library

Error logs

I don't know how to get them

Solution

Maybe using 6.50.53

Additional context

NaN

Device Environment

Android 12 One UI 5.1

Acknowledgements

This issue does not reproduce on unpatched YouTube or YT Music.
This issue is not a duplicate of an existing bug report.
I have chosen an appropriate title.
All requested information has been provided properly.
I have written the title and contents in English.

inotia00 · 2024-05-09T16:59:34Z

This is related to the Hide fullscreen ads setting.
just disable Hide fullscreen ads setting until the issue is resolved.

…s non-ad dialogs inotia00/ReVanced_Extended#1971

inotia00 · 2024-05-10T17:18:51Z

fixed in revanced-patches-4.8.0-dev.4

soyDESKTOP68A2MRFT · 2024-05-10T17:28:55Z

Have you fixed that problem when creating playlists?, or is it from google side? El vie, 10 de may. de 2024 12:19 p. m., inotia00 ***@***.***> escribió:

…

fixed in revanced-patches-4.8.0-dev.4 <https://github.com/inotia00/revanced-patches/releases/tag/v4.8.0-dev.4> — Reply to this email directly, view it on GitHub <#1971 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUVLCGTIXOTFU5ESMFW5OBLZBT6RDAVCNFSM6AAAAABHPEMKQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUHE4DMMJZGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

soyDESKTOP68A2MRFT · 2024-05-10T17:29:31Z

When i try to create a playlist the dialog disappears El vie, 10 de may. de 2024 12:19 p. m., inotia00 ***@***.***> escribió:

…

fixed in revanced-patches-4.8.0-dev.4 <https://github.com/inotia00/revanced-patches/releases/tag/v4.8.0-dev.4> — Reply to this email directly, view it on GitHub <#1971 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUVLCGTIXOTFU5ESMFW5OBLZBT6RDAVCNFSM6AAAAABHPEMKQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUHE4DMMJZGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

inotia00 · 2024-05-10T17:34:21Z

Are you sure you patched with revanced-patches-4.8.0-dev.4?

soyDESKTOP68A2MRFT · 2024-05-10T17:39:35Z

Is this problem in my reply resolved in this new release? El vie, 10 de may. de 2024 12:34 p. m., inotia00 ***@***.***> escribió:

…

Are you sure you patched with revanced-patches-4.8.0-dev.4? — Reply to this email directly, view it on GitHub <#1971 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUVLCGSJKL6R7XVFMDAHC7TZBUALFAVCNFSM6AAAAABHPEMKQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGAYDMMJTGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

soyDESKTOP68A2MRFT · 2024-05-10T17:40:01Z

I didn't El vie, 10 de may. de 2024 12:34 p. m., inotia00 ***@***.***> escribió:

…

Are you sure you patched with revanced-patches-4.8.0-dev.4? — Reply to this email directly, view it on GitHub <#1971 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUVLCGSJKL6R7XVFMDAHC7TZBUALFAVCNFSM6AAAAABHPEMKQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGAYDMMJTGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

soyDESKTOP68A2MRFT · 2024-05-10T17:40:11Z

But i will El vie, 10 de may. de 2024 12:34 p. m., inotia00 ***@***.***> escribió:

…

Are you sure you patched with revanced-patches-4.8.0-dev.4? — Reply to this email directly, view it on GitHub <#1971 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUVLCGSJKL6R7XVFMDAHC7TZBUALFAVCNFSM6AAAAABHPEMKQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGAYDMMJTGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

inotia00 · 2024-05-10T17:41:30Z

If you are using RVX Manager, you need to turn on the Use pre-releases setting.

This issue is fixed in the latest dev branch.

soyDESKTOP68A2MRFT · 2024-05-10T17:58:14Z

The playlist are working now, thanks El vie, 10 de may. de 2024 12:41 p. m., inotia00 ***@***.***> escribió:

…

If you are using rvx-manager, you need to turn on the Use pre-releases setting. This issue is fixed in the latest dev branch. — Reply to this email directly, view it on GitHub <#1971 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUVLCGR6XJYNBAJIXEDYTGDZBUBGBAVCNFSM6AAAAABHPEMKQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVGAYTKNBXGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

…s non-ad dialogs inotia00/ReVanced_Extended#1971

# [0.152.0-dev.8](v0.152.0-dev.7...v0.152.0-dev.8) (2024-05-16) ### Bug Fixes * **YouTube Music/Hide ads:** `Hide fullscreen ads` setting also closes non-ad dialogs inotia00/ReVanced_Extended#1971 ([7dd292d](7dd292d)) * **YouTube/Description components:** crash occurs when the title of the engagement panel is null inotia00/ReVanced_Extended#2008 ([e4ba2d0](e4ba2d0)) * **YouTube/Hide layout components:** add method to hide settings with whitelist inotia00/ReVanced_Extended#1964 ([10e5d1a](10e5d1a)) * **YouTube/Return YouTube Dislike:** dislike count sometimes not shown in Shorts inotia00/ReVanced_Extended#1565 ([f869a37](f869a37)) * **YouTube/Return YouTube Dislike:** wrong video id is used in shorts inotia00/ReVanced_Extended#1987 ([3868c2b](3868c2b)) * **YouTube/Settings:** settings values of excluded patches have changed due to incorrect settings alignment ([d706d1b](d706d1b)) * **YouTube/SponsorBlock:** pressing the fine adjustment buttons skips to the end of the video while creating a new SponsorBlock segment inotia00/ReVanced_Extended#1980 ([f683045](f683045)) * **YouTube/Spoof format stream data:** check audio tags first ([75e84a2](75e84a2)) * **YouTube/Spoof format stream data:** incorrect url is used ([2f86f6b](2f86f6b)) * **YouTube/Video playback:** default video quality applies even when video is playing inotia00/ReVanced_Extended#1959 ([5cc2c04](5cc2c04)) ### Features * **YouTube/Spoof format stream data:** check endpoint url is non-null ([a25d7d7](a25d7d7)) * **YouTube/Spoof format stream data:** improve hook method, fetch to `ANDROID_TESTSUITE` client ([ef50cf5](ef50cf5)) * **YouTube:** Add `Hide videos by duration` and `Hide videos by views count` greater than specified value ([inotia00#37](https://github.com/anddea/revanced-integrations/issues/37)) ([d15028c](d15028c))

inotia00 · 2024-05-26T09:38:31Z

fixed in revanced-patches-4.8.3

# [0.152.0](v0.151.0...v0.152.0) (2024-05-29) ### Bug Fixes * App crashes when resource not found ([6abcabc](6abcabc)) * **YouTube - Append timestamp information:** Ensure correct RTL layout ([027b948](027b948)) * **YouTube - Default video quality:** Revert back ([d6da339](d6da339)) * **YouTube - Hide action buttons:** Some action buttons are not hidden properly ([c37f238](c37f238)) * **YouTube - Hide feed components:** `Hide mix playlists` setting hides components in channel profile ([dc151ae](dc151ae)) * **YouTube - Hide keyword content:** Filter Shorts found in horizontal shelves ([25465e2](25465e2)) * **YouTube - Hide Shorts components:** Channel headers were hidden if Shorts is disabled ([5451719](5451719)) * **YouTube - Hide Shorts components:** Exclude `Hide sound metadata label` and `Hide video link label` from `Hide info panel` ([a510788](a510788)) * **YouTube - Hide Shorts components:** Hide Shorts in search result horizontal shelves ([2be49fc](2be49fc)) * **YouTube - Return YouTube Dislike:** Disabling `Show dislikes in Shorts` disabled dislikes everywhere ([#11](#11)) ([1b317db](1b317db)) * **YouTube - Return YouTube Dislike:** Dislike counts showing in views ([83bf7b2](83bf7b2)) * **YouTube - Return YouTube Dislike:** Fix some issues ([281dbe3](281dbe3)) * **YouTube - Return YouTube Dislike:** Subscribe icon is hidden ([95b34d4](95b34d4)) * **YouTube - Searchbar:** Hide searchbar in RYD and Sponsorblock sections ([#13](#13)) ([ed60bea](ed60bea)) * **YouTube - Searchbar:** Prevent searchbar appearing briefly when switching between fragments ([#14](#14)) ([584e6e3](584e6e3)) * **YouTube - Searchbar:** Restore original settings page if query is empty ([#12](#12)) ([9592bd5](9592bd5)) * **YouTube - Shorts components:** Update pattern for hide disabled comments ([c7b2fd4](c7b2fd4)) * **YouTube - SponsorBlock:** `Submit a new segment` button did not work ([395d3ce](395d3ce)) * **YouTube - SponsorBlock:** Pressing Now while manually editing a segment results in an error ([9521baa](9521baa)) * **YouTube - Spoof format stream data:** Some Uris are not hooked ([7e49ab3](7e49ab3)) * **YouTube - Video playback:** Default video quality sometimes does not apply when video is not loaded ([86b8130](86b8130)) * **YouTube Music/Hide ads:** `Hide fullscreen ads` setting also closes non-ad dialogs inotia00/ReVanced_Extended#1971 ([7dd292d](7dd292d)) * **YouTube/Description components:** crash occurs when the title of the engagement panel is null inotia00/ReVanced_Extended#2008 ([e4ba2d0](e4ba2d0)) * **YouTube/Hide layout components:** add method to hide settings with whitelist inotia00/ReVanced_Extended#1964 ([10e5d1a](10e5d1a)) * **YouTube/Return YouTube Dislike:** dislike count sometimes not shown in Shorts inotia00/ReVanced_Extended#1565 ([f869a37](f869a37)) * **YouTube/Return YouTube Dislike:** wrong video id is used in shorts inotia00/ReVanced_Extended#1987 ([3868c2b](3868c2b)) * **YouTube/Settings:** settings values of excluded patches have changed due to incorrect settings alignment ([d706d1b](d706d1b)) * **YouTube/SponsorBlock:** pressing the fine adjustment buttons skips to the end of the video while creating a new SponsorBlock segment inotia00/ReVanced_Extended#1980 ([f683045](f683045)) * **YouTube/Spoof format stream data:** check audio tags first ([75e84a2](75e84a2)) * **YouTube/Spoof format stream data:** incorrect url is used ([2f86f6b](2f86f6b)) * **YouTube/Video playback:** default video quality applies even when video is playing inotia00/ReVanced_Extended#1959 ([5cc2c04](5cc2c04)) * **YouTube:** App crashes when `SponsorBlock` patch is excluded ([e657bbd](e657bbd)) * **YT Music - Hide terms container:** Patch doesn't require restart to apply the changes ([e987b6d](e987b6d)) ### Features * Refactor and match ReVanced and inotia ([30ad38a](30ad38a)) * **YouTube - Fullscreen components:** `Hide related videos in quick actions` setting has been merged into the `Hide related video overlay` setting ([a9b973b](a9b973b)) * **YouTube - Hide layout components:** Add `Hide videos based on duration` ([b6bd93a](b6bd93a)) * **YouTube - Hide layout components:** Add an option to hide videos with views greater than specified value ([14d4756](14d4756)) * **YouTube - Hide shorts components:** Add separate option to hide in player ([67cfeb8](67cfeb8)) * **YouTube - Hide shorts components:** Hide comments button if disabled or with label "0" ([44f3c2f](44f3c2f)) * **YouTube - Overlay buttons:** Add `Whitelist` overlay button ([564a044](564a044)) * **YouTube - Player components:** Add setting toggle for `Hide suggested video end screen` ([d020bc8](d020bc8)) * **YouTube - Settings:** Add ability to search in summaries and list entries ([fbe9e53](fbe9e53)) * **YouTube - Settings:** Add search bar for settings ([681cea9](681cea9)) * **YouTube - Toolbar components:** Remove `Hide trending searches` setting ([b14f20c](b14f20c)) * **YouTube Music - Player components:** Add `Enable black player background` setting ([d27d362](d27d362)) * **YouTube Music - Player components:** Add `Hide audio video switch toggle` setting ([68238da](68238da)) * **YouTube/Spoof format stream data:** check endpoint url is non-null ([a25d7d7](a25d7d7)) * **YouTube/Spoof format stream data:** improve hook method, fetch to `ANDROID_TESTSUITE` client ([ef50cf5](ef50cf5)) * **YouTube:** Add `Hide videos by duration` and `Hide videos by views count` greater than specified value ([inotia00#37](https://github.com/anddea/revanced-integrations/issues/37)) ([d15028c](d15028c)) * **YouTube:** Add `Spoof client` patch ([010f879](010f879)) * **YouTube:** Add support versions `19.19.39` - `19.20.34` ([3c4ccc3](3c4ccc3)) * **YouTube:** Hide live chat replay in fullscreen ([e8184a1](e8184a1)) * **YouTube:** Remove `Spoof test client` patch ([782b25b](782b25b)) ### Reverts * default landscape mode timeout ([f46db5d](f46db5d))

soyDESKTOP68A2MRFT added the Bug report Something isn't working label May 9, 2024

inotia00 changed the title ~~bug: playlist don't getting created by new playlist button, nor by save button on queue~~ bug(YouTube Music/Hide ads): Hide fullscreen ads setting also closes non-ad dialogs May 9, 2024

inotia00 added a commit to inotia00/revanced-integrations that referenced this issue May 10, 2024

fix(YouTube Music/Hide ads): Hide fullscreen ads setting also close…

1419cae

…s non-ad dialogs inotia00/ReVanced_Extended#1971

inotia00 added a commit to inotia00/revanced-patches that referenced this issue May 10, 2024

fix(YouTube Music/Hide ads): Hide fullscreen ads setting also close…

0156128

…s non-ad dialogs inotia00/ReVanced_Extended#1971

inotia00 added the Partially resolved Fixed in certain versions label May 10, 2024

inotia00 mentioned this issue May 10, 2024

bug: can't create new playlists #1988

Closed

5 tasks

anddea pushed a commit to anddea/revanced-integrations that referenced this issue May 16, 2024

fix(YouTube Music/Hide ads): Hide fullscreen ads setting also close…

7dd292d

…s non-ad dialogs inotia00/ReVanced_Extended#1971

inotia00 mentioned this issue May 21, 2024

bug: Can't create a new playlist on latest version of Revanced Extended Manager, Patcher, and Music #2054

Closed

5 tasks

inotia00 removed the Partially resolved Fixed in certain versions label May 26, 2024

inotia00 closed this as completed May 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bug(YouTube Music/Hide ads): `Hide fullscreen ads` setting also closes non-ad dialogs #1971

bug(YouTube Music/Hide ads): `Hide fullscreen ads` setting also closes non-ad dialogs #1971

soyDESKTOP68A2MRFT commented May 9, 2024

inotia00 commented May 9, 2024

inotia00 commented May 10, 2024

soyDESKTOP68A2MRFT commented May 10, 2024 via email

soyDESKTOP68A2MRFT commented May 10, 2024 via email

inotia00 commented May 10, 2024

soyDESKTOP68A2MRFT commented May 10, 2024 via email

soyDESKTOP68A2MRFT commented May 10, 2024 via email

soyDESKTOP68A2MRFT commented May 10, 2024 via email

inotia00 commented May 10, 2024 •

edited

Loading

soyDESKTOP68A2MRFT commented May 10, 2024 via email

inotia00 commented May 26, 2024

bug(YouTube Music/Hide ads): Hide fullscreen ads setting also closes non-ad dialogs #1971

bug(YouTube Music/Hide ads): Hide fullscreen ads setting also closes non-ad dialogs #1971

Comments

soyDESKTOP68A2MRFT commented May 9, 2024

Type

Tools used

Application

Bug description

Error logs

Solution

Additional context

Device Environment

Acknowledgements

inotia00 commented May 9, 2024

inotia00 commented May 10, 2024

soyDESKTOP68A2MRFT commented May 10, 2024 via email

soyDESKTOP68A2MRFT commented May 10, 2024 via email

inotia00 commented May 10, 2024

soyDESKTOP68A2MRFT commented May 10, 2024 via email

soyDESKTOP68A2MRFT commented May 10, 2024 via email

soyDESKTOP68A2MRFT commented May 10, 2024 via email

inotia00 commented May 10, 2024 • edited Loading

soyDESKTOP68A2MRFT commented May 10, 2024 via email

inotia00 commented May 26, 2024

bug(YouTube Music/Hide ads): `Hide fullscreen ads` setting also closes non-ad dialogs #1971

bug(YouTube Music/Hide ads): `Hide fullscreen ads` setting also closes non-ad dialogs #1971

inotia00 commented May 10, 2024 •

edited

Loading