Clarify in-app strings

[KobeW50]

No description provided.

[KobeW50]

In YT, under ReVanced Extended > Feed > Video filter, the Hide recommended videos setting description says it hides videos with the 'Only for membership' tag.

On my client I have a 'Members only' tag, shown below.

Are these the same, and should the setting description say Videos with the 'Members only' tag.?

[KobeW50]

More questions:

1. The spoof format stream data setting says it has the following limitation:

"There may be about 5 seconds of buffering when the video starts."

Would this be better? "There may be about 5 seconds of buffering when videos start."

---

2. In the Alternative thumbnails settings, there is an option for "Player playlists, recommendations"

What exactly does this mean? (Example below)

---

3.

In ReVanced Extended > Player > Player buttons, there is the experimental setting of Override download action button.

This setting is somewhat out-of-place because it is for the download button below the video rather than the overlay download button.

The current description is shown in this screenshot:

Should I change it to the following?

"Download button below the video player opens the native in-app downloader."

Or do you intend to move it to the Action button settings? (I can open a bug report)

Or neither?

---

4.

In the Player settings, the note for the Disable speed overlay setting says that, "This setting does not force the speed overlay to be enabled."

What does this mean? (Image below for context)

---

5.

What does this setting do?

---

6.

What does this setting do?

[inotia00]

In YT, under ReVanced Extended > Feed > Video filter, the Hide recommended videos setting description says it hides videos with the 'Only for membership' tag.

If I remember correctly, this is the feature suggested by @YT-Advanced.
He may know more accurately.

[inotia00]

1. The spoof format stream data setting says it has the following limitation:

Would this be better? "There may be about 5 seconds of buffering when videos start."

: Yes this explanation is clear

2. In the Alternative thumbnails settings, there is an option for "Player playlists, recommendations"

What exactly does this mean? (Example below)

: This setting was added when merging ReVanced's commit
I think it's a thumbnail included in Playlists and Horizontal shelves that appear in the feed.

3. In ReVanced Extended > Player > Player buttons, there is the experimental setting of Override download action button.
Should I change it to the following?
"Download button below the video player opens the native in-app downloader."
Or do you intend to move it to the Action button settings? (I can open a bug report)
Or neither?

: This setting overrides the behavior of both the download button in the action bar and the download button in the feed flyout menu. (Unlike YouTube Music)

Therefore, it is more appropriate to separate it into the External downloader category.

4. In the Player settings, the note for the Disable speed overlay setting says that, "This setting does not force the speed overlay to be enabled."

What does this mean? (Image below for context)

: The code related to the speed overlay was added in YouTube v18.19.36+, but Google restricted it to be activated only in YouTube v18.36.39+. (server side limitation)

Therefore, for users who have patched YouTube v18.29.38 ~ v18.35.36, the speed overlay will not be activated even if you enable or disable the Disable speed overlay setting.

Likewise, when spoofing to old clients with the same settings as Spoof app version, the speed overlay is not activated.

One additional line of explanation has been added to prevent user confusion.

5. What does this setting do?

: Expand video description setting is the most unstable and buggy of the Experimental Flags.

To prevent operation in unintended situations, a process has been added to check the panel's title string. (refer to screenshot)

The panel's title string depends on the user's system language, and the video description will only expand if the correct panel's title string is entered.

6. What does this setting do?

: If I were to explain this, I would have to explain how the patch is implemented.
(It's a little complicated.)

When the value of the Keep landscape mode flag is TRUE, the screen orientation can only be changed by the 'fullscreen button'.
(The screen orientation cannot be changed in any way other than that.)

If the flag value is always TRUE, the user cannot switch to landscape mode (fullscreen) using back button or swipe gesture.

Therefore, the value of the flag always remains FALSE until the user enters fullscreen, turns off the screen, and turns the screen back on.

After the screen is turned on, the flag value switches to TRUE, and after the screen is unlocked, the flag value must be restored to FALSE.
(To prevent issues where the screen orientation does not change through the back button or swipe gesture)

The problem is that there is no way to check whether the user has unlocked the screen.

Therefore, I adopted a method of changing the value of the flag to FALSE after a set time.

In other words, this is the time interval from 'When the user turns on the screen' to 'When the value of the flag is restored to FALSE'.

If this time interval is too short, fullscreen may not remain when the user unlocks it.

If this time interval is too long, the user will not be able to change the screen orientation via the back button or swipe gesture after unlocking.

[KobeW50]

3
: This setting overrides the behavior of both the download button in the action bar and the download button in the feed flyout menu. (Unlike YouTube Music)

Therefore, it is more appropriate to separate it into the External downloader category.

Is it ok if I change the setting descriptions to "Native download button opens the native in-app downloader." and "Native download button opens your external downloader."?

[inotia00]

"Native download button opens your external downloader."

This looks better

[KobeW50]

2. In the Alternative thumbnails settings, there is an option for "Player playlists, recommendations"

: This setting was added when merging ReVanced's commit I think it's a thumbnail included in Playlists and Horizontal shelves that appear in the feed.

After a short amount of testing, this option changes the thumbnails of the end-card recommendations, but I am not certain if this is all that it does. I asked the author of the upstream PR and am awaiting a response. Once its effects are confirmed, I will try to make the setting title clearer (in a separate PR).

Other than that, this PR is ready for review.

[inotia00]

Thanks