Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify patch descriptions #52

Merged
merged 8 commits into from
May 27, 2024
Merged

Clarify patch descriptions #52

merged 8 commits into from
May 27, 2024

Conversation

KobeW50
Copy link
Collaborator

@KobeW50 KobeW50 commented May 26, 2024

No description provided.

@KobeW50
Copy link
Collaborator Author

KobeW50 commented May 26, 2024

Should the Hide double tap overlay filter patch description also say have the phrase "at compile time"?

@inotia00
Copy link
Owner

yeah it's better to do this to keep patch descriptions consistent

inotia00 and others added 6 commits May 27, 2024 12:16
…onbg/PlayerButtonBackgroundPatch.kt

Co-authored-by: KobeW50 <84587632+KobeW50@users.noreply.github.com>
…ortsDimmingPatch.kt

Co-authored-by: KobeW50 <84587632+KobeW50@users.noreply.github.com>
…nimatedLikePatch.kt

Co-authored-by: KobeW50 <84587632+KobeW50@users.noreply.github.com>
…nimatedButtonBackgroundPatch.kt

Co-authored-by: KobeW50 <84587632+KobeW50@users.noreply.github.com>
@KobeW50
Copy link
Collaborator Author

KobeW50 commented May 27, 2024

Added for the ytm patches as well

@inotia00
Copy link
Owner

Thanks

@inotia00 inotia00 merged commit 2ce77b1 into inotia00:dev May 27, 2024
@KobeW50
Copy link
Collaborator Author

KobeW50 commented May 27, 2024

I forgot about Shorts outline button

@inotia00
Copy link
Owner

Don't worry, there are still a lot of things to clarify in the patch description and settings

Just merge it in next release cycle

@KobeW50
Copy link
Collaborator Author

KobeW50 commented May 27, 2024

there are still a lot of things to clarify in the patch description and settings

What do you have in mind?

@inotia00
Copy link
Owner

inotia00 commented May 27, 2024

The most representative example is the following issue:
inotia00/ReVanced_Extended#2051

While refactoring the RVX patch, I lowercase all proper nouns like Shorts, Clips, Thanks, and Library
(both in the settings and in the patch description)

You will understand if you refer to the official ReVanced settings

in ReVanced:
Disable resuming Shorts player

in RVX:
Disable resuming shorts player

@KobeW50
Copy link
Collaborator Author

KobeW50 commented May 27, 2024

Should these proper nowns also be capitalized in patch names? For example, should Change shorts repeat state become Change Shorts repeat state?

(I'm guessing not bec of cli, but i just want to make sure)

@inotia00
Copy link
Owner

Should these proper nowns also be capitalized in patch names? For example, should Change shorts repeat state become Change Shorts repeat state?

yeah we need to change the patch name too

@PROBLEMCHYLD

This comment was marked as spam.

@KobeW50
Copy link
Collaborator Author

KobeW50 commented May 28, 2024

@PROBLEMCHYLD

Ask here or create a bug report in this repository.

@selfmusing
Copy link

Not sure where to post but I can't select anything on Android Oxygen 14 OnePlus Screenshot_2024-05-28-10-58-17-53_84d3000e3f4017145260f7618db1d683

Bruh , just reduce the size of termux window using your fingers to zoom-in / zoom-out on that patch screen!!

@PROBLEMCHYLD
Copy link

Yeah it did work, but I shouldn't have to keep adjusting my terminal every time I run a new program. Yes, it's a bug. Thanks the work around helps. It only happened when I updated to the latest. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants