-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify patch descriptions #52
Conversation
...ain/kotlin/app/revanced/patches/youtube/layout/playerbuttonbg/PlayerButtonBackgroundPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/youtube/layout/dimming/ShortsDimmingPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/youtube/layout/animated/AnimatedLikePatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/youtube/layout/animated/AnimatedButtonBackgroundPatch.kt
Outdated
Show resolved
Hide resolved
Should the |
yeah it's better to do this to keep patch descriptions consistent |
…onbg/PlayerButtonBackgroundPatch.kt Co-authored-by: KobeW50 <84587632+KobeW50@users.noreply.github.com>
…ortsDimmingPatch.kt Co-authored-by: KobeW50 <84587632+KobeW50@users.noreply.github.com>
…nimatedLikePatch.kt Co-authored-by: KobeW50 <84587632+KobeW50@users.noreply.github.com>
…nimatedButtonBackgroundPatch.kt Co-authored-by: KobeW50 <84587632+KobeW50@users.noreply.github.com>
Added for the ytm patches as well |
Thanks |
I forgot about |
Don't worry, there are still a lot of things to clarify in the patch description and settings Just merge it in next release cycle |
What do you have in mind? |
The most representative example is the following issue: While refactoring the RVX patch, I lowercase all proper nouns like You will understand if you refer to the official ReVanced settings in ReVanced: in RVX: |
Should these proper nowns also be capitalized in patch names? For example, should (I'm guessing not bec of cli, but i just want to make sure) |
yeah we need to change the patch name too |
This comment was marked as spam.
This comment was marked as spam.
Ask here or create a bug report in this repository. |
Yeah it did work, but I shouldn't have to keep adjusting my terminal every time I run a new program. Yes, it's a bug. Thanks the work around helps. It only happened when I updated to the latest. Thanks again. |
No description provided.