Database errors after activating #246

Closed
FlorianBrinkmann opened this Issue Dec 14, 2016 · 6 comments

Projects

None yet

3 participants

@FlorianBrinkmann

Hi!

I activated the current Version 2.4.8 on a 4.7 WordPress multisite install and get the following 3 database errors:

DESCRIBE wp_mlp_languages;
Table 'db.wp_mlp_languages' doesn't exist

DESCRIBE wp_multilingual_linked;
Table 'db.wp_multilingual_linked' doesn't exist

DESCRIBE wp_mlp_site_relations;
Table 'db.wp_mlp_site_relations' doesn't exist

After reloading the page with the installed plugins I get the following errors:

ALTER TABLE wp_mlp_languages ADD KEY `` (`http_name`)
Incorrect index name ''

ALTER TABLE wp_multilingual_linked ADD KEY `` (`ml_blogid`,`ml_elementid`)
Incorrect index name ''

ALTER TABLE wp_mlp_site_relations ADD KEY `` (`site_1`,`site_2`)
Incorrect index name ''
@tfrommen tfrommen was assigned by bueltge Dec 14, 2016
@FlorianBrinkmann

Now I tried the code here from GitHub and with that I only get the first set of errors (Table doesn’t exist). After reloading the page, no further errors.

@tfrommen tfrommen added this to the v2.4.9 milestone Dec 16, 2016
@tfrommen
Member
tfrommen commented Dec 16, 2016 edited

Hi!

Well, the first set of database errors is not (really) the fault of MultilingualPress, but rather due to dbDelta() being used to alter a table that does not yet exist, see this post, for example, or google for "dbdelta error describe" or so. :)
It's somewhat annoying, yes, but the result is like we want it to be: the tables have been created successfully.
And once the tables are there, dbDelta() won't trigger any errors anymore, so this is only the case when installing MultilingualPress (not on any subsequent re-activations).

The second set of errors has been introduced by the changed KEY (or INDEX) behavior of WordPress 4.6, I believe.
I definitely fixed this for master already (e.g., here), and I thought I also did so in a patch release for the 2.4 branch - which I obviously did not (yet). Sorry.

Expect a release for this by next week. :)

Cheers,
Thorsten

@FlorianBrinkmann

Hi Thorsten,

thanks for the explanation!

Expect a release for this by next week. :)

That’s great, thanks for your work :)

Have a nice weekend!
Florian

@tfrommen
Member

Hi Florian,

can you confirm the latest changes in the 2.4 branch work for you? You can also just grab the ZIP file.

Just let me know and a release will follow within the next days.

Thanks,
Thorsten

@FlorianBrinkmann

Hi Thorsten,

looks good, no Incorrect index name errors! :)

Cheers,
Florian

@tfrommen tfrommen modified the milestone: v2.5.0, v2.4.9 Dec 23, 2016
@tfrommen
Member

Closed with 391109f.

@tfrommen tfrommen closed this Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment