Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug FeeTooSmall even after genEraTweakBlock #2340

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Debug FeeTooSmall even after genEraTweakBlock #2340

merged 1 commit into from
Jun 21, 2021

Conversation

TimSheard
Copy link
Contributor

Trying to debug

CHAIN level Properties
    collection of Ada preservation properties:                         FAIL (5970.12s)
      *** Failed! (after 222 tests):
      Exception while generating shrink-list:
        LEDGER sigGen: [[UtxowFailure (WrappedShelleyEraFailure (UtxoFailure (FeeTooSmallUTxO (Coin 502) (Coin 2))))]]
        CallStack (from HasCallStack):
          error, called at src/Test/Shelley/Spec/Ledger/Generator/Trace/Ledger.hs:181:25 in shelley-spec-ledger-test-0.1.0.0-inplace:Test.Shelley.Spec.Ledger.Generator.Trace.Ledger

@TimSheard TimSheard force-pushed the ts-feeTooSmallAftergenEraTweakBlock branch from dcf537b to 36d9444 Compare June 21, 2021 16:25
@TimSheard
Copy link
Contributor Author

This has now been cleaned up. Intermittent failures addressed by

  1. Account for the cost of storing a script, in addition to the cost of running it.
    2)Added genEraTweakBlock, and genEraDone as ways to discard badly formed Tx ans Block.

JaredCorduan
JaredCorduan reviewed Jun 21, 2021
View reviewed changes
alonzo/test/lib/Test/Cardano/Ledger/Alonzo/AlonzoEraGen.hs
@@ -271,6 +280,11 @@ bigStep, bigMem :: Word64
bigStep = 999 -- 9999999990
bigMem = 500 -- 50000000

instance HasField "totExunits" (Tx (AlonzoEra c)) ExUnits where
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we had to copy the ValidatedTx era instance since here we have a Core.Tx era? Is there a way to combine them... 🤔

JaredCorduan
JaredCorduan approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'll be happy to have these consistently generating valid traces again, thank you!

@TimSheard
Fix some intermittent Nightly failures.
36d9444 
Account for the cost of storing a script, in addition to the cost of running it.
Added genEraTweakBlock, and genEraDone as ways to discard badly formed transactions ans blocks.
@JaredCorduan JaredCorduan merged commit f5de153 into master Jun 21, 2021
@iohk-bors iohk-bors bot deleted the ts-feeTooSmallAftergenEraTweakBlock branch June 21, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimSheard @JaredCorduan