Add update payload to chain traces #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100 characters is not suitable for working with two vertical panes on a laptop, with a font size that is legible for people with less than optimal vision (like @dnadales :) ).
…dorsements See `updateProposalAndVotesGen` and `protocolVersionEndorsementGen`. In preparation for adding the update payload to the `CHAIN` traces.
... where the number of characters in the system tags were not being counted. [skip ci]
…t to decrease certain protocol parameter values to prevent the signal production (blocks, transactions, etc) from stopping.
…h endorsements" coverage check.
nc6
approved these changes
Jul 18, 2019
| @@ -31,7 +32,7 @@ instance STS BHEAD where | |||
|
|
|||
| data PredicateFailure BHEAD | |||
| = HashesDontMatch -- TODO: Add fields so that users know the two hashes that don't match | |||
| | HeaderSizeTooBig -- TODO: Add more information here as well. | |||
| | HeaderSizeTooBig BlockHeader Natural Natural | |||
| NoGenUTxO -> pure [] | ||
|
|
||
| (anOptionalUpdateProposal, aListOfVotes) <- |
There was a problem hiding this comment.
For consistency, does this not want to be guarded in the same way with shouldGenUpdate?
There was a problem hiding this comment.
Yeah, I was being lazy here since we generate update payload only sporadically, but you're right, we should try to adhere to the principle of least surprise :)
| @@ -1102,7 +1128,7 @@ ppsUpdateFrom pps = do | |||
| `increasingProbabilityAt` (0, 1) | |||
|
|
|||
| nextFactorA :: Gen Int | |||
| nextFactorA = | |||
| nextFactorA = --pure _factorA | |||
nc6
approved these changes
Jul 18, 2019
It allowed to produce a maximum transaction size that was bigger than the current maximum block size.
…als do not change the maximum transaction-size" - Increase the trace length to 300 in the `onlyValidSignalsAreGenerated @CHAIN` propoerty
kevinhammond
pushed a commit
that referenced
this pull request
Oct 28, 2019
- Lower the coverage threshold for "at least 10% of the update proposals do not
change the maximum transaction-size"
- Increase the trace length to 300 in the `onlyValidSignalsAreGenerated @CHAIN`
propoerty
- Fix the update generator. It allowed to produce a maximum transaction size
that was bigger than the current maximum block size.
- Guard the `newMaxBkSize - 1` against underflows
- Lower 10% the bounds for the "at least 10% of the proposals get enough
endorsements" coverage check.
- Generate `CHAIN` delegation payload only in 30% of the cases.
- Tweak the coverage metrics to account for the fact that we do not want to
decrease certain protocol parameter values to prevent the signal production
(blocks, transactions, etc) from stopping.
- Set a memory limit for the tests in `cs-blockchain`
- Fix the abstract size test where the number of characters in the system tags
were not being counted.
- Fix arithmetic underflow when checking validity of proposed script version.
- Factor out functions for generating update proposal and votes, and
endorsements. See `updateProposalAndVotesGen` and
`protocolVersionEndorsementGen`.
- Ignore `stack` lock file.
- Limit the line width to 80. 100 characters is not suitable for working with
two vertical panes on a laptop, with a font size that is legible for people
with less than optimal vision (like @dnadales :) ).
nc6
pushed a commit
that referenced
this pull request
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #621