Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Core.hs to each era that has a TxBody class #3036

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Added Core.hs to each era that has a TxBody class #3036

merged 1 commit into from
Sep 21, 2022

Conversation

Soupstraw
Copy link
Contributor

This PR moves the [Era]EraTxBody classes from each era to the Core module of that era.

closes #2932

teodanciu
teodanciu reviewed Sep 15, 2022
View reviewed changes
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I noticed we didn't do the suggestion from the ticket to

re-export the whole of Cardno.Ledger.Core module and Cardano.Ledger.[Era].Core from a previous era from it as well

  • by choice or an omission?

@Soupstraw
Copy link
Contributor Author

Looks good to me. I noticed we didn't do the suggestion from the ticket to

re-export the whole of Cardno.Ledger.Core module and Cardano.Ledger.[Era].Core from a previous era from it as well

* by choice or an omission?

Fixed it now

lehins
lehins requested changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one conceptual change need, otherwise looks great.

eras/shelley/impl/src/Cardano/Ledger/Shelley/Core.hs Outdated Show resolved Hide resolved
eras/shelley-ma/impl/src/Cardano/Ledger/ShelleyMA/Core.hs Outdated Show resolved Hide resolved
eras/babbage/impl/src/Cardano/Ledger/Babbage/Core.hs Outdated Show resolved Hide resolved
eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Core.hs Outdated Show resolved Hide resolved
@Soupstraw Soupstraw force-pushed the jj/classes-to-core branch 2 times, most recently from 278cd89 to dafb836 Compare September 16, 2022 11:37
lehins
lehins approved these changes Sep 20, 2022
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few redundant things, but otherwise looks great

eras/shelley/impl/src/Cardano/Ledger/Shelley/Core.hs Outdated Show resolved Hide resolved
eras/shelley/impl/src/Cardano/Ledger/Shelley/Core.hs Outdated Show resolved Hide resolved
eras/shelley/impl/src/Cardano/Ledger/Shelley/Core.hs Outdated Show resolved Hide resolved
@Soupstraw Soupstraw force-pushed the jj/classes-to-core branch 2 times, most recently from 52e800e to 501bbdf Compare September 21, 2022 09:37
@Soupstraw @lehins
Added Core.hs to each era that has a TxBody class
3a72c41 
Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
@Soupstraw Soupstraw merged commit b60ecae into master Sep 21, 2022
@iohk-bors iohk-bors bot deleted the jj/classes-to-core branch September 21, 2022 11:03
@lehins lehins mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@teodanciu teodanciu Awaiting requested review from teodanciu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Classes defined in each era should go into Core module
3 participants
@Soupstraw @teodanciu @lehins