Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Redeemer codec #3263

Closed
wants to merge 1 commit into from
Closed

Fix Redeemer codec #3263

wants to merge 1 commit into from

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Jan 18, 2023 •
edited
Loading

Description

Closes #3237

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu (which can be run with scripts/fourmolize.sh
  • Self-reviewed the diff

@aniketd aniketd requested a review from lehins January 18, 2023 14:19
@aniketd aniketd force-pushed the aniketd/fix-redeemer-codec branch 2 times, most recently from e270a7c to ae452e3 Compare January 18, 2023 17:00
@aniketd
Copy link
Contributor Author

aniketd commented Jan 18, 2023

@lehins This is ready for your initial quick review of the implementation. I still need to add some tests and necessary instances.

lehins
lehins requested changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is looking great. Some tests and it'll be ready to go

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/TxWits.hs Outdated Show resolved Hide resolved
eras/alonzo/impl/src/Cardano/Ledger/Alonzo/TxWits.hs Outdated Show resolved Hide resolved
eras/alonzo/impl/src/Cardano/Ledger/Alonzo/TxWits.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Decoding/Decoder.hs Show resolved Hide resolved
@aniketd aniketd marked this pull request as ready for review January 19, 2023 20:18
lehins
lehins approved these changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. There are just a few improvements on testing that can be done, other than that it can be merged no problem.

libs/cardano-ledger-binary/testlib/Test/Cardano/Ledger/Binary/RoundTrip.hs Outdated Show resolved Hide resolved
eras/conway/test-suite/src/Test/Cardano/Ledger/Conway/Serialisation/Roundtrip.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-binary/testlib/Test/Cardano/Ledger/Binary/RoundTrip.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-binary/testlib/Test/Cardano/Ledger/Binary/RoundTrip.hs Outdated Show resolved Hide resolved
eras/conway/test-suite/src/Test/Cardano/Ledger/Conway/Serialisation/Roundtrip.hs Show resolved Hide resolved
@aniketd
Copy link
Contributor Author

aniketd commented Jan 23, 2023

It was discovered that FromCBORGroup for RdmrPtr uses a listLen of 2, and therefore 4 happens to be the correct number of elements in the codec.

@aniketd aniketd closed this Jan 23, 2023
@aniketd aniketd mentioned this pull request Jan 23, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gracefully fix Redeemer (de)serialization
2 participants
@aniketd @lehins