Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ConwayGenesis as TranslationContext for Conway #3368

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Set ConwayGenesis as TranslationContext for Conway #3368

merged 1 commit into from
Apr 5, 2023

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Apr 5, 2023 •
edited
Loading

Description

This was an oversight. Translation context is always equal to genesis type for each era, except Shelley

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the CHANGELOG.md for affected package
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins enabled auto-merge April 5, 2023 10:38
JaredCorduan
JaredCorduan approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

(Does this somehow explain the "this should be hex" test failure you were seeing in node?)

@lehins lehins merged commit f10f06f into master Apr 5, 2023
@iohk-bors iohk-bors bot deleted the lehins/conway-genesis-as-translation-context branch April 5, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@Soupstraw Soupstraw Soupstraw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lehins @JaredCorduan @Soupstraw