Create TotalDeposits events during all eras #3404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
reviewed
May 8, 2023
|
good catch @kderme ! thanks for making the fix. After node 8.0.0.0 is released I will be doing another release of the ledger libraries. |
It was only created on Shelley. It's still missing from Conway.
kderme
force-pushed
the
kderme/total_deposits
branch
from
f49d62b
to
38ed7c8
Compare
kderme
force-pushed
the
kderme/total_deposits
branch
from
38ed7c8
to
fdff4f9
Compare
JaredCorduan
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TotalDepositsappeared as event only during the Shelley era, since next eras have a differentEvent (EraRule "UTXO")instance. This pr makes sure the event appears during all eras.Would it be possible to have new releases with this? I've updated the Changelogs assuming that.
Checklist
CHANGELOG.mdfor affected package.cabalfiles are updatedfourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)