Upgradeable families #3596
Merged
Upgradeable families #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/upgradeable-families
branch
2 times, most recently
from
bff478b
to
b4f0b7b
Compare
7 tasks
lehins
force-pushed
the
lehins/upgradeable-families
branch
from
b4f0b7b
to
77bf5fd
Compare
lehins
force-pushed
the
lehins/upgradeable-families
branch
from
77bf5fd
to
f2a204d
Compare
nc6
approved these changes
Aug 9, 2023
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Core/Binary.hs
Outdated
Show resolved
Hide resolved
lehins
force-pushed
the
lehins/upgradeable-families
branch
2 times, most recently
from
ec0711d
to
f1659cd
Compare
Consensus already defines a similar function. There is no need for it to live there especially since it can be used in other downstream applications and testing
The idea behind tests is to serialize a type in the previous era and deserialize it in the current era, while checking that upgrading functionality produces the same result. Noteable type family that does not translate through serialization is the Script on the Allegra/Alonzo boundary, hence it is treated specially in tests.
* Upgrade of TxCerts can fail on Babbage/Conway boundary, hence slightly different interface than other upgrade functions. * Includes upgradeability test for TxCert
lehins
force-pushed
the
lehins/upgradeable-families
branch
from
f1659cd
to
c43a997
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Take care of part of #3618
Adds
upgradeTxOut,upgradeTxAuxData,upgradeScriptandupgradeTxCertas well as:cardano-ledger-[era]package that didn't have one. See Consolidate allcardano-ledger-[era]-testpackage #3623 for more info on a long goal with respect to test suites.eraNamethat can be used in any place where textual representation of an era is needed (this can subsume similar functionality from consensus)ToExprinstances for more types. Needed for testing.EraTxAuxDatainstances into their own modules for Babbage and ConwayChecklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)