Add conway-specific certs to deposit/refunds #3700
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3696
I suspect that this implementation may be incorrect, because:
RegDepositTxCert
andUnRegDepositTxCert
(inConway.UTxO
) separately fromRegTxCert
andUnRegTxCert
(inMary.UTxO
) they could be considered essentially the same, because these could be mixed up submissions in the sameTx
, and need to be calculated together in Conway?RegDepositDelegTxCert
that has no equivalentUn_
counterpart (as it does not need one), but then, the natural question to ask myself is, should this also be considered to be accounted for along with the group of certs being tracked in point 1?In other words, should the deposit/refund calculation be the following:
and
unified in conway and not partially separated out (for reuse) in
shelleyProducedValue
andgetConsumedMaryValue
?Let me know what you guys think!
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)