Implement the remaining upgradable families #3714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
force-pushed
the
nc/upgradable-families
branch
from
bc47e5c
to
5c2617c
Compare
|
Rebased, solved merge conflicts and compilation problems caused by changes happening since the PR |
teodanciu
reviewed
Sep 14, 2023
lehins
approved these changes
Sep 14, 2023
teodanciu
force-pushed
the
nc/upgradable-families
branch
2 times, most recently
from
6c179a8
to
4244b9e
Compare
teodanciu
reviewed
Sep 22, 2023
teodanciu
force-pushed
the
nc/upgradable-families
branch
3 times, most recently
from
4cb2c89
to
466daee
Compare
- `upgradeTxBody` - `upgradeTxWits` - `upgradeTx` We introduce a few helpers to assist, which follow the same pattern outside of an era-indexed family: - `upgradeData` - `upgradeTxDats` - `upgradeRedeemers`
Also implement 'Memoized' for 'ShelleyTx', which admits a trivial instance but was missing it.
This happens if the Mary transaction attempts to pass a protocol parameter update which updates the min ADA, since this field is not effectively translatable to Alonzo.
We switch this off in Alonzo, since the translation path does not directly deserialise, rather pulling together the body and witnesses data separately.
- We need to avoid comparing the size for 'Sized' fields. - 'coinsPerUTxOByte' is translated through binary translation naively as 'coinsPerUTxOWord'. We need to reflect this to preserve transaction validity. - Two other protocol parameters were removed and will cause the translation to fail, so must be accounted for in the upgrade.
and use it in Allegra and Mary upgrade
teodanciu
force-pushed
the
nc/upgradable-families
branch
3 times, most recently
from
99978f2
to
48e400d
Compare
teodanciu
force-pushed
the
nc/upgradable-families
branch
from
48e400d
to
9527ec0
Compare
|
Updated CHANGELOG and adjusted versions: set cardano-ledger-core depedency lower bound to 1.7 for all ears. Merging! |
👂 🦻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the remaining upgrade functions described in #3618
upgradeTxBody,upgradeTxWits, andupgradeTxToExprin various places throughout the code in order to print the diffsisValidand not doing translation via deserialisation of the Tx.coinsPerUTxOWordwill deserialise correctly in Babbage but with an altered meaning. We account for this in the upgrade function. An alternative would be to explicitly fail on any transactions that attempted to update this field, but this would require that the translation logic unpack the transaction, and doesn't seem worth it since these will never occur.Resolves #3618
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)