Removed Shaped instance for Rep
#3734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good to get the input of @lehins and @TimSheard on this one |
MaximilianAlgehed
force-pushed
the
PR-typerep-remove-shaped
branch
3 times, most recently
from
7271448
to
375e2a9
Compare
lehins
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Another amazing simplification. Perfect!!
Would be nice to @TimSheard review on this as well, however.
MaximilianAlgehed
force-pushed
the
PR-typerep-remove-shaped
branch
3 times, most recently
from
1e6d5ae
to
b7e7d0a
Compare
MaximilianAlgehed
force-pushed
the
PR-typerep-remove-shaped
branch
from
b7e7d0a
to
944f1d6
Compare
|
@lehins there appear to be some flaky tests. Should we log these somewhere to make sure someone can go back and fix them at some point? |
`TypeRep` based instances
MaximilianAlgehed
force-pushed
the
PR-typerep-remove-shaped
branch
from
944f1d6
to
8a435bb
Compare
No point. Everyone knows about it, so it is just a matter of time and priority till we get to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
and replace its uses with
TypeRepbased instancesChecklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)