Cardano-Perf regression: UMap.size regression fix #3758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
approved these changes
Sep 26, 2023
lehins
force-pushed
the
cardano-perf-regression/umap-base-perf
branch
from
74d02e1
to
5cdf654
Compare
|
I'm interested in if these changes change performance of the ledger. Is there a way we could get this data? |
Specifically: - decodeAddress28 - getEitherAddrBabbageTxOut - umElem functions in umap - txIxFromIntegral - certIxFromIntegral - word16FromInteger
lehins
force-pushed
the
cardano-perf-regression/umap-base-perf
branch
from
5cdf654
to
d5185db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is just an assemblage of performance tweaks that I have found by auditing the code base, inspecting performance and tickyticky profiles. Most of the tweaks are inlining some key functions so that GHC can further optimize them at their respective call sites with
case-of-known-constructorwhich leads to better Core.cc @dnadales