Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent updating protocol version with PParamUpdate #3766

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Prevent updating protocol version with PParamUpdate #3766

merged 2 commits into from
Sep 29, 2023

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Sep 28, 2023 •
edited

Description

Added type safety for the protocol version field of ConwayPParams so that is not possible to change that field with a PParamsUpdate

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/protver-field branch 3 times, most recently from a8d00e0 to b5cc00b Compare September 28, 2023 13:28
@Soupstraw Soupstraw marked this pull request as ready for review September 28, 2023 13:28
lehins
lehins requested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

libs/cardano-ledger-core/src/Cardano/Ledger/Core/Era.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-core/src/Cardano/Ledger/Core/PParams.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-core/src/Cardano/Ledger/Core/PParams.hs Outdated Show resolved Hide resolved
eras/shelley/impl/src/Cardano/Ledger/Shelley/PParams.hs Show resolved Hide resolved
@Soupstraw Soupstraw force-pushed the jj/protver-field branch 7 times, most recently from f053263 to dd5255d Compare September 29, 2023 09:47
lehins
lehins approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lehins lehins merged commit 065f467 into master Sep 29, 2023
12 checks passed
@iohk-bors iohk-bors bot deleted the jj/protver-field branch September 29, 2023 23:25
@Soupstraw Soupstraw mentioned this pull request Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@aniketd aniketd Awaiting requested review from aniketd

@teodanciu teodanciu Awaiting requested review from teodanciu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Soupstraw @lehins