Update cabal_build_tests scripts to allow testing builds at commits. #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
force-pushed
the
jdral/update-cabal-build-tests
branch
3 times, most recently
from
f61f238
to
002539d
Compare
jorisdral
force-pushed
the
jdral/update-cabal-build-tests
branch
from
002539d
to
aaa568c
Compare
jorisdral
force-pushed
the
jdral/update-cabal-build-tests
branch
from
aaa568c
to
c97f582
Compare
The scripts were previously only aimed at build-testing `cardano-node` tags. The script can now also build-test specific commit hashes. Other changes: * Include installation of missing package dependencies (openssl, lmdb). * Include Secp256k1 installation. * "Parameterise" the script with cabal and ghc versions. * Installing of `cardano-cli` and `cardano-node` executables simplified.
jorisdral
force-pushed
the
jdral/update-cabal-build-tests
branch
from
c97f582
to
60cff45
Compare
catch-21
suggested changes
Jun 27, 2022
catch-21
reviewed
Jun 27, 2022
iohk-bors bot
added a commit
to IntersectMBO/cardano-node
that referenced
this pull request
Jun 28, 2022
4107: Update getting-started installation dependencies r=james-iohk a=james-iohk Update installation dependencies for Fedora and Ubuntu inline with automated test IntersectMBO/cardano-node-tests#1191 Co-authored-by: James <74595920+james-iohk@users.noreply.github.com>
catch-21
approved these changes
Jun 28, 2022
|
LGTM. Thanks @jorisdral |
mkoura
pushed a commit
that referenced
this pull request
Aug 25, 2022
…1191) * Update cabal_build_tests scripts to allow testing builds at commits. The scripts were previously only aimed at build-testing `cardano-node` tags. The script can now also build-test specific commit hashes. Other changes: * Include installation of missing package dependencies (openssl, lmdb). * Include Secp256k1 installation. * "Parameterise" the script with cabal and ghc versions. * Installing of `cardano-cli` and `cardano-node` executables simplified. * Process PR comments: Missing Fedora packages, typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scripts previously were only aimed at build-testing
cardano-nodetags. The script can now also build-test specific commit hashes.Other changes:
cardano-cliandcardano-nodeexecutables simplified.