Rework Windows CI to use MSYS2 #4184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
jasagredo
changed the title
jasagredo
requested review from
Jimbo4350,
newhoggy,
dcoutts,
erikd and
JaredCorduan
as code owners
jasagredo
added
nix
newhoggy
reviewed
Jul 15, 2022
newhoggy
approved these changes
Jul 15, 2022
Jimbo4350
approved these changes
Jul 15, 2022
jasagredo
force-pushed
the
jasagredo/fix-windows-ci-MSYS2-on-master
branch
from
f6c35fc
to
12f37e1
Compare
Pacman99
approved these changes
Jul 18, 2022
Pacman99
reviewed
Jul 18, 2022
jasagredo
force-pushed
the
jasagredo/fix-windows-ci-MSYS2-on-master
branch
6 times, most recently
from
9f9ec98
to
a65dd57
Compare
iohk-bors bot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Jul 18, 2022
3901: Windows Github Actions now uses MSYS2 r=Jasagredo a=Jasagredo # Description Windows Github actions CI makes use of chocolatey and some hydra artifacts to run. This PR unifies the approach for Windows [by using MSYS2](https://github.com/msys2/setup-msys2). Done in the same style as [this PR in `cardano-node`](IntersectMBO/cardano-node#4184) Co-authored-by: Javier Sagredo <jasataco@gmail.com>
iohk-bors bot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
Jul 18, 2022
3901: Windows Github Actions now uses MSYS2 r=Jasagredo a=Jasagredo # Description Windows Github actions CI makes use of chocolatey and some hydra artifacts to run. This PR unifies the approach for Windows [by using MSYS2](https://github.com/msys2/setup-msys2). Done in the same style as [this PR in `cardano-node`](IntersectMBO/cardano-node#4184) Co-authored-by: Javier Sagredo <jasataco@gmail.com>
jasagredo
force-pushed
the
jasagredo/fix-windows-ci-MSYS2-on-master
branch
from
a65dd57
to
8e229c7
Compare
|
bors r+ |
|
Build succeeded: |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 4, 2023
4612: Cardano Node 1.35.6 aka Single Relay P2P release r=coot a=coot Update `ouroboros-network-0.2.0.0`. This also cherry-picked CI commits: * e745ca8 from #4184 * #4513 * #4526 * #4590 Co-authored-by: Michael Peyton Jones <michael.peyton-jones@iohk.io> Co-authored-by: Marcin Szamotulski <coot@coot.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows Github Actions is at the moment a mixture of several different solutions, namely:
This PR unifies the Windows Github actions approach into using MSYS2 and installing everything in a standardized way.
Also, the different
cabal.project.local.$RUNNERfiles are no longer required.