Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows Github Actions Workflow for building Haskell #4513

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Oct 6, 2022

@newhoggy newhoggy changed the title Fix Windows Github Actions Workflow for building Haskeel Fix Windows Github Actions Workflow for building Haskell Oct 6, 2022
@newhoggy newhoggy marked this pull request as ready for review October 10, 2022 22:06
@newhoggy
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Oct 11, 2022
4513: Fix Windows Github Actions Workflow for building Haskell r=newhoggy a=newhoggy

Inspired by IntersectMBO/ouroboros-network#4059

Thanks `@amesgen` !

Co-authored-by: John Ky <john.ky@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 11, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from Jimbo4350.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@newhoggy
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 11, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit f01d540 into master Oct 11, 2022
@iohk-bors iohk-bors bot deleted the newhoggy/fix-windows-gha branch October 11, 2022 22:46
@angerman
Copy link
Contributor

angerman commented Oct 12, 2022

This really should be a shared action in input-output-hk/devx that all IOG project can use.

The fact that we replicate the same logic across multiple projects is not good. It means each project can fail in its own very unique ways and we need to maintain the same code across multiple projects multiple times.

iohk-bors bot added a commit that referenced this pull request Feb 4, 2023
4612: Cardano Node 1.35.6 aka Single Relay P2P release r=coot a=coot

Update `ouroboros-network-0.2.0.0`.

This also cherry-picked CI commits:
* e745ca8 from #4184
* #4513
* #4526
* #4590

Co-authored-by: Michael Peyton Jones <michael.peyton-jones@iohk.io>
Co-authored-by: Marcin Szamotulski <coot@coot.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants