-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Github Actions now uses MSYS2 #3901
Conversation
d3174c8
to
e4c66cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks wonderful!
Only other thing: Do you have evidence that caching is working? In e4c66cb (latest commit at time of writing), all dependencies are still built from scratch.
e4c66cb
to
132f3e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, unfortunate that runner.os
doesn't work in the shell:
expression 🤔
Either way, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jasagredo thanks for taking care of it. Btw, what triggered moving away of |
cc @coot (I'm not sure if quote replying in github notifies the author) |
4073904
to
4eb7719
Compare
99ca11a
to
adc93fb
Compare
18ccfd9
to
9df6a5a
Compare
bors r+ |
3901: Windows Github Actions now uses MSYS2 r=Jasagredo a=Jasagredo # Description Windows Github actions CI makes use of chocolatey and some hydra artifacts to run. This PR unifies the approach for Windows [by using MSYS2](https://github.com/msys2/setup-msys2). Done in the same style as [this PR in `cardano-node`](IntersectMBO/cardano-node#4184) Co-authored-by: Javier Sagredo <jasataco@gmail.com>
Timed out. |
bors retry |
3901: Windows Github Actions now uses MSYS2 r=Jasagredo a=Jasagredo # Description Windows Github actions CI makes use of chocolatey and some hydra artifacts to run. This PR unifies the approach for Windows [by using MSYS2](https://github.com/msys2/setup-msys2). Done in the same style as [this PR in `cardano-node`](IntersectMBO/cardano-node#4184) Co-authored-by: Javier Sagredo <jasataco@gmail.com>
Timed out. |
e08246f
to
29aa6bb
Compare
29aa6bb
to
7f07c40
Compare
3911: Fix GH Actions Windows CI caching r=amesgen a=amesgen # Description In #3901, the store path used for caching was `C:\cabal\config\store` instead of the correct `C:\cabal\store`. This was due a mix up of the path separators (`/` vs `\`). Also, we bump the cache version as we want to override the previous (empty) cache. For evidence that this works, see [this run](https://github.com/input-output-hk/ouroboros-network/runs/7417675263?check_suite_focus=true), in particular how the `Build dependencies` and the `Build projects [build]` finish almost instantly. Co-authored-by: Alexander Esgen <alexander.esgen@iohk.io>
3911: Fix GH Actions Windows CI caching r=amesgen a=amesgen # Description In #3901, the store path used for caching was `C:\cabal\config\store` instead of the correct `C:\cabal\store`. This was due a mix up of the path separators (`/` vs `\`). Also, we bump the cache version as we want to override the previous (empty) cache. For evidence that this works, see [this run](https://github.com/input-output-hk/ouroboros-network/runs/7417675263?check_suite_focus=true), in particular how the `Build dependencies` and the `Build projects [build]` finish almost instantly. Co-authored-by: Alexander Esgen <alexander.esgen@iohk.io>
…i-MSYS2 Windows Github Actions now uses MSYS2
3911: Fix GH Actions Windows CI caching r=amesgen a=amesgen # Description In #3901, the store path used for caching was `C:\cabal\config\store` instead of the correct `C:\cabal\store`. This was due a mix up of the path separators (`/` vs `\`). Also, we bump the cache version as we want to override the previous (empty) cache. For evidence that this works, see [this run](https://github.com/input-output-hk/ouroboros-network/runs/7417675263?check_suite_focus=true), in particular how the `Build dependencies` and the `Build projects [build]` finish almost instantly. Co-authored-by: Alexander Esgen <alexander.esgen@iohk.io>
Description
Windows Github actions CI makes use of chocolatey and some hydra artifacts to run. This PR unifies the approach for Windows by using MSYS2.
Done in the same style as this PR in
cardano-node
Checklist
interface-CHANGELOG.md
interface-CHANGELOG.md