tx-generator: Use distinct keys/addresses for benchmarking phases #4486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcFontaine
requested review from
deepfire,
denisshevchenko,
jutaro,
mgmeier,
fmaste and
cleverca22
as code owners
MarcFontaine
force-pushed
the
mafo/tx-generator-addresses
branch
from
ddf375c
to
9eb6174
Compare
mgmeier
approved these changes
Sep 28, 2022
MarcFontaine
force-pushed
the
mafo/tx-generator-addresses
branch
from
9eb6174
to
7173847
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 28, 2022
4466: Added changelogs for releases between 1.34.0 and 1.35.3 r=Jimbo4350 a=LaurenceIO Updated api, cli, node, and submit-api changelogs on master with changes in 1.34.0, 1.34.1, 1.35.0, 1.35.1, 1.35.2, and 1.35.3 releases. Thanks to `@ltouro` for highlighting a typo. 4484: Update error message for incorrectly witnessed collateral inputs r=Jimbo4350 a=Jimbo4350 Resolves: #4479 4486: tx-generator: Use distinct keys/addresses for benchmarking phases r=MarcFontaine a=MarcFontaine This is useful for debugging the tx-generator. Hard coded addresses: `addr_test1vzj7zv9msmdasvy5nc9jhnn2gqvrvu33v5rlg332zdfrkugklxkau` : outputs of the splitting phase (value not Plutus). `addr_test1vz4qz2ayucp7xvnthrx93uhha7e04gvxttpnuq4e6mx2n5gzfw23z` : final outputs of the benchmarking phase. Co-authored-by: LaurenceIO <73659683+LaurenceIO@users.noreply.github.com> Co-authored-by: Jordan Millar <jordan.millar@iohk.io> Co-authored-by: MarcFontaine <MarcFontaine@users.noreply.github.com>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from MarcFontaine, cleverca22, deepfire, denisshevchenko, fmaste, jutaro, and/or mgmeier.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
MarcFontaine
force-pushed
the
mafo/tx-generator-addresses
branch
from
7173847
to
491c096
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for debugging the tx-generator.
Hard coded addresses:
addr_test1vzj7zv9msmdasvy5nc9jhnn2gqvrvu33v5rlg332zdfrkugklxkau: outputs of the splitting phase (value not Plutus).addr_test1vz4qz2ayucp7xvnthrx93uhha7e04gvxttpnuq4e6mx2n5gzfw23z: final outputs of the benchmarking phase.