-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAD-455 log versioning: make pretty #542
Conversation
d94284c
to
edc0507
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- nice idea about "era", but not necessary.
- the cabal file "cardano-node.cabal" defines the version of the node
- this version needs to be added to 'env' from module "Paths_cardano_node"
111e120
to
10ec4cf
Compare
@CodiePP, done. |
Config.setTextOption logConfig "appversion" ver | ||
Config.setTextOption logConfig "appcommit" gitRev | ||
T.putStrLn $ "ver: " <> ver | ||
T.putStrLn $ "rev: " <> gitRev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this debug output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah gotcha, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes/explanations needed
62c1394
to
b9cb962
Compare
then Cardano.BM.Backend.Editor.plugin logConfig trace switchBoard | ||
>>= loadPlugin switchBoard | ||
else pure () | ||
when (p > 0) $ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
358e426
to
b9cb962
Compare
bors r+ |
542: CAD-455 log versioning: make pretty r=CodiePP a=deepfire We used to have the following in the structured log: ``` {"at":"2020-02-05T23:39:27.05Z","env": "fromList [(\"value\",String \"Release-1.0.0\")]:0.1.10.1","ns":["cardano","node-metrics"],"data":{},"app":[],"msg":"IO.rchar = 24964 B","...} ``` This makes it more useful -- by tracking node version & commit id in the `env` field: ``` {"at":"2020-02-05T23:39:27.05Z","env":"1.5.0:79a04","ns":["cardano","node-metrics"],"data":{},"app":[],"msg":"IO.rchar = 24964 B","...} ``` # Note This depends on input-output-hk/iohk-monitoring-framework#514 being merged first. Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
Build failed |
bors r+ |
This PR was included in a batch with a merge conflict, it will be automatically retried |
Merge conflict |
b9cb962
to
5c225e7
Compare
bors r+ |
542: CAD-455 log versioning: make pretty r=CodiePP a=deepfire We used to have the following in the structured log: ``` {"at":"2020-02-05T23:39:27.05Z","env": "fromList [(\"value\",String \"Release-1.0.0\")]:0.1.10.1","ns":["cardano","node-metrics"],"data":{},"app":[],"msg":"IO.rchar = 24964 B","...} ``` This makes it more useful -- by tracking node version & commit id in the `env` field: ``` {"at":"2020-02-05T23:39:27.05Z","env":"1.5.0:79a04","ns":["cardano","node-metrics"],"data":{},"app":[],"msg":"IO.rchar = 24964 B","...} ``` # Note This depends on input-output-hk/iohk-monitoring-framework#514 being merged first. Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
Build succeeded |
We used to have the following in the structured log:
This makes it more useful -- by tracking node version & commit id in the
env
field:Note
This depends on input-output-hk/iohk-monitoring-framework#514 being merged first.