Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

Move the configuration to the cardano-node #238

Closed
ksaric opened this issue Jul 29, 2019 · 0 comments
Closed

Move the configuration to the cardano-node #238

ksaric opened this issue Jul 29, 2019 · 0 comments
Assignees
@ksaric
Milestone
NOD005 Minimal in...

Comments

@ksaric
Copy link
Contributor

ksaric commented Jul 29, 2019

The plan is that somebody moves the config types that are specific to the node out of the cardano-shell and into the cardano-node. The principle is that the shell is a general-purpose library, and the node is a specific user of the library.
The types were originally incubated in the shell because there wasn't anywhere else really to put them at the time.

The cardano-ledger shouldn't depend on monitoring which depends on cardano-shell.
The cardano-ledger only needs to depend on contra-tracer as the network and consensus do.
@ksaric ksaric self-assigned this Jul 29, 2019
@ksaric ksaric mentioned this issue Aug 6, 2019
Closed
ksaric added a commit that referenced this issue Aug 8, 2019
@ksaric
[GH-238] Move the configuration to the cardano-node.
c76bf17
@ksaric ksaric mentioned this issue Aug 8, 2019
Merged
ksaric added a commit that referenced this issue Aug 9, 2019
@ksaric
[GH-238] Move the configuration to the cardano-node. (#250)
9bbfc43
@ksaric ksaric mentioned this issue Aug 9, 2019
Closed
@CodiePP CodiePP closed this as completed Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ksaric ksaric

Labels
None yet
Projects
None yet
Milestone
NOD005 Minimal integration with Node ...
Development

No branches or pull requests
2 participants
@ksaric @CodiePP