[CSL-2343] Remove wallet/node directory

[gromakovsky]

It's not used anymore, so I suppose it should be removed as part of CSL-2343.

[Hithroc]

Should scripts/launch/demo-with-new-wallet-api.sh also be removed? Asking here because this seems like relevant pull request.

[gromakovsky]

Hm, yes, I think so.

[gromakovsky]

Actually no, I don't think so, because there is --new-wallet flag in it. So probably it should be left for now.

[akegalj]

I believe this is good. Before merging I would wait for some time so that we are sure nothing is broken so that we can easily revert. For now only with https://iohk.myjetbrains.com/youtrack/issue/CSL-2343 - but we don't want to make more of similar PRs (that would be harder to track to revert).

For example - the renaming is also not working as expected https://iohk.myjetbrains.com/youtrack/issue/CSL-2364

In short: looks good but lets not pull the trigger just yet

[adinapoli-iohk]

I think this is fine. My preference would be to pull the trigger instead. It's a single commit anyway, that's trivial to revert. Will leave @gromakovsky to decide.

[adinapoli-iohk]

@KtorZ @parsonsmatt I think this PR is worthwhile reviving, as we removed the executable flag from wallet.cabal but we are still keeping the content inside wallet/node/* alive for no good reason.

Would you resurrect this one and give it another spin?

[akegalj]

Closed in favour of #3104