Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction with amount 0 on http bridge fails with error HTTP 500 #364

Closed
piotr-iohk opened this issue Jun 4, 2019 · 1 comment
Closed
Assignees

Comments

@piotr-iohk
Copy link
Contributor

piotr-iohk commented Jun 4, 2019

Release Operating System Cause
next Linux Code v Configuration v Environment v Human v Unknown

Context

The transaction with 0 amount on Byron node should fail more gracefully than HTTP 500. cf #335 (comment)

Steps to Reproduce

Run transaction with 0 amount from API or CLI.

Expected behavior

There should be an error (perhaps HTTP 400 or 403 on the API) and a graceful error message about 0 amount transaction not being supported on Byron node.

Actual behavior

HTTP 500

That's embarassing. It looks like I've created an invalid transaction that could
not be parsed by the node. Here's an error message that may help with 
debugging: Transaction failed verification: output with no credited value

Resolution Plan

PR

Number Base
#445 master

QA

  • Added a new error branch when creating transaction, now triggered from the http-bridge and tested via an integration test (see TRANS_CREATE_09)
@piotr-iohk
Copy link
Contributor Author

Looking good. Just added few more scenarios in #458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants