Fix new warnings in HLint v3.1.6 #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jonathanknowles
approved these changes
Jul 8, 2020
|
bors r+ |
Build failed |
KtorZ
approved these changes
Jul 8, 2020
paweljakubas
approved these changes
Jul 8, 2020
|
bors r+ |
Build failed |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 8, 2020
1875: Move sync progress logic to new module r=Anviking a=Anviking # Issue Number #1869 # Overview - [x] Make the sync progress logic easier to grasp by moving it to its own module - [x] Add a note about the calculation going to break in era-transitions # Comments - I believe we may have to have to provide _several_ methods of calculating the sync-progress. Maybe we need a different one for jormungandr. I think a new module is neat regardless. <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 1877: Fix new warnings in HLint v3.1.6 r=Anviking a=rvl ### Overview HLint v3.1.6 can find more unused language extensions. ### Comments CI version update in PR #1857. Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Build failed (retrying...) |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 8, 2020
1865: withdrawals as part of the coin selection r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #1861 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - 12b28f7 📍 **take withdrawals into account, one level earlier, during the coin selection** Still to be done: - Make sure it's correctly done in the largest-first algorithm - Add some test scenario that show the influence of the withdrawal - 547b130 📍 **unit-test the newly introduced 'proportionallyTo'** Getting this one wrong would be quite bad :s - 975f726 📍 **add unit tests showing how withdrawal impacts the random coin selection** > 💡 NOTE > > I've chosen not to treat the withdrawal as a single _input_, but more as a "money pot" that is proportionally distributed amongst change output, so that it contributes to every output, based on their size. This is to avoid having a small output consuming the entire withdrawal for itself. Note sure if I'll keep the approach in the end, I'll have the night to think about it. # Comments <!-- Additional comments or screenshots to attach if any --> - [ ] TODO: take into account the withdrawal when doing largest-first (and testing it) - [ ] TODO: echo the error message change on "ErrInputsDepleted" to integration tests relying on that message. <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 1877: Fix new warnings in HLint v3.1.6 r=Anviking a=rvl ### Overview HLint v3.1.6 can find more unused language extensions. ### Comments CI version update in PR #1857. Co-authored-by: KtorZ <matthias.benkort@gmail.com> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Build failed (retrying...) |
Canceled |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 8, 2020
1857: Better nix-shell r=KtorZ a=rvl
### Overview
- Uses new Haskell.nix features to put haskell tools in the nix-shell.
- Adds bech32, cardano-address, cardano-tx to the nix-shell.
- Adds these tools to the release archives ("Adrestia tool belt").
- Adds automated tests to the release archives.
- Add nix option for building libraries and exes with profiling enabled.
- Add bash completion for select tools in nix-shell.
### Comments
- Merge #1877 first.
Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
iohk-bors bot
added a commit
that referenced
this pull request
Jul 10, 2020
1857: Better nix-shell r=KtorZ a=rvl ### User story ADP-369 ### Overview - Uses new Haskell.nix features to put haskell tools in the nix-shell. - Adds bech32, cardano-address, cardano-tx to the nix-shell. - Adds these tools to the release archives ("Adrestia tool belt"). - Adds automated tests to the release archives. - Add nix option for building libraries and exes with profiling enabled. - Add bash completion for select tools in nix-shell. ### Comments - Merge #1877 first. 1894: Getting minimum utxo r=paweljakubas a=paweljakubas # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #1893 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have extended `ProtocolParameters` and `ApiNetworkParameters` - [x] I have updated swagger - [x] I have used minimumUtxoValue in feeOpts in determination of dustThreshold - [x] I have updated testing - [x] I have handled migration # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: Pawel Jakubas <pawel.jakubas@iohk.io> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
HLint v3.1.6 can find more unused language extensions.
Comments
CI version update in PR #1857.