Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Typhon wallet registration | NPG-000 #657

Merged
merged 123 commits into from
Feb 26, 2024
Merged

feat: Typhon wallet registration | NPG-000 #657

merged 123 commits into from
Feb 26, 2024

Conversation

alicechaitea
Copy link
Contributor

@alicechaitea alicechaitea commented Jan 17, 2024 •
edited

Description

Added wallet registration UI automated testing for Typhon

Fixes # 654

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@alicechaitea alicechaitea changed the title feat: added playwright feat(playwright): added playwright support | NPG-1234 Jan 17, 2024
@alicechaitea alicechaitea changed the title feat(playwright): added playwright support | NPG-1234 feat(playwright): added playwright support Jan 17, 2024
@alicechaitea alicechaitea changed the title feat(playwright): added playwright support added playwright support Jan 17, 2024
@alicechaitea alicechaitea changed the title added playwright support feat: Added playwright support | NPG-000 Jan 17, 2024
@alicechaitea alicechaitea changed the title feat: Added playwright support | NPG-000 feat: Typhon wallet registration | NPG-000 #657 Jan 17, 2024
@kukkok3 kukkok3 changed the title feat: Typhon wallet registration | NPG-000 #657 feat: Typhon wallet registration | NPG-000 Jan 17, 2024
kukkok3
kukkok3 reviewed Jan 17, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@alicechaitea
fix: reaching the typhon wallet extension
fa8e281
@alicechaitea
fix: reaching the typhon wallet extension
ade6d33
@alicechaitea
fix: enabled access to extension
23c9ff3
@alicechaitea
fix: relative path didn't work
848d0e3
@alicechaitea
fix: moved files around
d00cdba
@alicechaitea
fix: playwright not recognizing static element
779bf82
@alicechaitea
fix: file update
08d70b8
@alicechaitea
feat: added second click
7261cd9
@alicechaitea
feat: add reset user state
108252e
@alicechaitea
feat: added dotenv
214845e
@alicechaitea
feat: added credentials storage and module to match element with seed…
b3c3fc0 
… phrase
@alicechaitea
fix: retrieval of credentials not working properly
14c8567
@alicechaitea
fix: path to file storing credentials
938c34d
@alicechaitea
fix: selector should be working now
19a4845
@alicechaitea
feat: added selector for continueButton
b58529f
@alicechaitea
feat: fetch seedword according to position and fill in field
a462339
@alicechaitea
feat: added logout and remove wallet flow
334e0c4
@alicechaitea
feat: added logout and remove wallet flow
c1e1f6c
kukkok3
kukkok3 reviewed Feb 16, 2024
View reviewed changes
.gitignore Show resolved Hide resolved
alicechaitea
alicechaitea commented Feb 21, 2024
View reviewed changes
Copy link
Contributor Author

@alicechaitea alicechaitea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed all comments as of now

tests/wallet-automation/package.json Outdated Show resolved Hide resolved
tests/wallet-automation/test-1.spec.ts Outdated Show resolved Hide resolved
alicechaitea
alicechaitea commented Feb 21, 2024
View reviewed changes
Copy link
Contributor Author

@alicechaitea alicechaitea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all changes are checked

@alicechaitea alicechaitea marked this pull request as ready for review February 22, 2024 03:49
kukkok3
kukkok3 previously approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM you just need to address my last comment, then it can be merged

@kukkok3 kukkok3 enabled auto-merge (squash) February 26, 2024 13:14
kukkok3
kukkok3 approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukkok3 kukkok3 merged commit 4b48c5e into main Feb 26, 2024
26 of 27 checks passed
@kukkok3 kukkok3 deleted the tests/typhon-registration branch February 26, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukkok3 kukkok3 kukkok3 approved these changes

@stevenj stevenj Awaiting requested review from stevenj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alicechaitea @stevenj @kukkok3