GitHub CI: switch to actions/cache@v2 #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It was not the index state (though v1 does bug out and gives us an old cache value), it's a regression in nightly cargo: rust-lang/cargo#8351 |
mzabaluev
force-pushed
the
github-cache-v2
branch
from
59930ba
to
0cbcad6
Compare
This comment has been minimized.
This comment has been minimized.
added 3 commits
June 12, 2020 16:16
There's a bug in v1 that keeps the registry index cache in an old state that's started breaking the builds. There is still a bug in v2 as well that results in separate cache values made by Windows jobs due to issues with parameter normalization, but this will self-correct once the action bug is fixed.
This resulted in the index being stored at cargo-index-v2- and used from that key in subsequent runs.
mzabaluev
force-pushed
the
github-cache-v2
branch
from
0cbcad6
to
b400b9d
Compare
That was not true either, it was a typo on my part. Well, now that I have ported the thing anyway... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in v1 that keeps the registry index cache in an old state that's started breaking the builds.
There is still a bug in v2 as well, that results in separate cache values made by Windows jobs due to issues with parameter normalization, but this will self-correct once the action bug is fixed.