Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression in README parsing #8351

Closed
Mark-Simulacrum opened this issue Jun 11, 2020 · 5 comments · Fixed by #8353
Closed

regression in README parsing #8351

Mark-Simulacrum opened this issue Jun 11, 2020 · 5 comments · Fixed by #8353
Labels
C-bug Category: bug P-high Priority: High regression-from-stable-to-nightly Regression in nightly that previously worked in stable.

Comments

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jun 11, 2020 •
edited by ehuss
Loading

Update

This has been fixed and the next nightly (2020-06-13) should contain the fix assuming rust-lang/rust#73266 lands. Nightly releases are usually published around 00:30 to 01:00 UTC.

Original issue

As of rust-lang/rust#73198 (presumably #8277), Cargo fails to find README in some published crates, leading to failures at build time:

error: failed to download `encoding-index-japanese v1.20141219.5`

Caused by:
  unable to get packages from source

Caused by:
  failed to parse manifest at `/home/mark/.cargo/registry/src/github.com-1ecc6299db9ec823/encoding-index-japanese-1.20141219.5/Cargo.toml`

Caused by:
  readme file with name '../../../README.md' was not found

Reproduction:

$ cp -pri ~/.cargo/registry/src/github.com-*/encoding-index-japanese-1.20141219.5 ./
$ cd encoding-index-japanese-1.20141219.5
$ cargo read-manifest
error: failed to parse manifest at `/tmp/tmp.8aqcVQDq2K/encoding-index-japanese-1.20141219.5/Cargo.toml`

Caused by:
  readme file with name '../../../README.md' was not found

Note that this hasn't hit nightly yet but it's likely too late to revert it before it does. This is breaking rustc-perf at least (and probably lots of other places that depend on crates published without READMEs included).
@Mark-Simulacrum Mark-Simulacrum added C-bug Category: bug regression-from-stable-to-nightly Regression in nightly that previously worked in stable. labels Jun 11, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Jun 11, 2020
Merged
@ehuss ehuss added the P-high Priority: High label Jun 11, 2020
@ehuss
Copy link
Contributor

ehuss commented Jun 11, 2020

I'll take a look.

@ehuss ehuss mentioned this issue Jun 11, 2020
Merged
@bors bors closed this as completed in 79c769c Jun 11, 2020
@ehuss ehuss pinned this issue Jun 12, 2020
@dtolnay dtolnay mentioned this issue Jun 12, 2020
Merged
@ehuss
Copy link
Contributor

ehuss commented Jun 12, 2020

Just going to reopen until the next nightly is published.

@ehuss ehuss reopened this Jun 12, 2020
@ehuss ehuss mentioned this issue Jun 12, 2020
Closed
@calebcartwright calebcartwright mentioned this issue Jun 12, 2020
Merged
@kitsuneninetails
Copy link

Yup. We saw this in our CI/CD systems this morning. Caused quite a stir and a ton of lost time debugging until we realized it was the nightly version. Unfortunate this crept in. Are the no tests for this regression in place? Should we add them?

@ehuss
Copy link
Contributor

ehuss commented Jun 12, 2020 •
edited
Loading

A smoke test is being added in rust-lang/rust#73267 to catch issues like this.

@taiki-e taiki-e mentioned this issue Jun 12, 2020
Merged
@PurpleBooth PurpleBooth mentioned this issue Jun 12, 2020
Closed
@dtolnay dtolnay mentioned this issue Jun 12, 2020
Closed
@jonas-schievink jonas-schievink mentioned this issue Jun 12, 2020
Closed
@mzabaluev mzabaluev mentioned this issue Jun 12, 2020
Merged
mtreinish added a commit to mtreinish/retworkx that referenced this issue Jun 12, 2020
@mtreinish
Temporarily pin nightly version used for builds
98e4e2e 
In the most recent nightly build of cargo a regression slipped in around
handling of READMEs in published crates [1]. Unfortunately this breaks CI
builds because a 3rd level dependency (pyo3->inventory->ctor) triggers
this regression. The issue has been corrected in cargo and the next
nightly should fix this. However, to unblock things in the meantime this
commit pins the nightly version to a known working version. We can
simply revert this after the fix has been released.

[1] rust-lang/cargo#8351
@mtreinish mtreinish mentioned this issue Jun 12, 2020
Closed
@taiki-e taiki-e mentioned this issue Jun 12, 2020
Closed
@twittner twittner mentioned this issue Jun 12, 2020
Merged
@oconnor663 oconnor663 mentioned this issue Jun 12, 2020
Closed
@calixteman calixteman mentioned this issue Jun 12, 2020
Closed
This was referenced Jun 12, 2020
Merged
Merged
@julien1619 julien1619 mentioned this issue Jun 12, 2020
Closed
@dignifiedquire dignifiedquire mentioned this issue Jun 12, 2020
Merged
@ispivey ispivey mentioned this issue Jun 12, 2020
Closed
ispivey added a commit to cloudflare/wrangler-legacy that referenced this issue Jun 12, 2020
@ispivey
Disable nightly builds due to upstream crate parsing issue
9aa1a5c 
Fixes #1380

Working around rust-lang/cargo#8351
@ispivey ispivey mentioned this issue Jun 12, 2020
Merged
@oconnor663 oconnor663 mentioned this issue Jun 12, 2020
Closed
@cuviper cuviper mentioned this issue Jun 12, 2020
Merged
@rbradford rbradford mentioned this issue Jun 12, 2020
Merged
@taiki-e taiki-e mentioned this issue Jun 12, 2020
Merged
@asomers asomers mentioned this issue Jun 12, 2020
Merged
@kngwyu kngwyu mentioned this issue Jun 13, 2020
Merged
@mzabaluev mzabaluev mentioned this issue Jun 13, 2020
Merged
@ehuss
Copy link
Contributor

ehuss commented Jun 14, 2020

This should be fixed now.

@ehuss ehuss closed this as completed Jun 14, 2020
@ehuss ehuss unpinned this issue Jun 14, 2020
@pietroalbini pietroalbini mentioned this issue Jun 14, 2020
Merged
6 tasks
@russcam russcam mentioned this issue Jun 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: bug P-high Priority: High regression-from-stable-to-nightly Regression in nightly that previously worked in stable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix failure with missing readme. ehuss/cargo
3 participants
@ehuss @Mark-Simulacrum @kitsuneninetails