Merge branch 'develop' into feature/ddw-684-improve-ntp-handling

CHANGELOG.md

@@ -35,6 +35,8 @@ Changelog
 
 ### Fixes
 
+- Fixed Staking screen ([PR 1461](https://github.com/input-output-hk/daedalus/pull/1461))
+- Improved small UI and copy elements ([PR 1459](https://github.com/input-output-hk/daedalus/pull/1459))
 - Fixed shutting down screen top priority ([PR 1428](https://github.com/input-output-hk/daedalus/pull/1428))
 - Fixed screen flashes during Daedalus loading ([PR 1444](https://github.com/input-output-hk/daedalus/pull/1444))
 - Removes files pushed without running Prettier ([PR 1445](https://github.com/input-output-hk/daedalus/pull/1445))
@@ -54,6 +56,8 @@ Changelog
 
 ### Chores
 
+- Improved the "Ada redemption" menu item UX by disabling the option while Daedalus is out of sync ([PR 1458](https://github.com/input-output-hk/daedalus/pull/1458))
+- Added `themes:check` script for checking missing definitions on createTheme object ([PR 1424](https://github.com/input-output-hk/daedalus/pull/1424))
 - Refactored the Loading screen, adding containers for each overlay ([PR 1446](https://github.com/input-output-hk/daedalus/pull/1446))
 - Added button to open local state directory on Daedalus Diagnostics Screen ([PR 1438](https://github.com/input-output-hk/daedalus/pull/1438))
 - Updated the list of contributors on the "About" screen ([PR 1450](https://github.com/input-output-hk/daedalus/pull/1450))

gulpfile.js

@@ -3,6 +3,7 @@ const webpack = require('webpack');
 const webpackStream = require('webpack-stream');
 const shell = require('gulp-shell');
 const electronConnect = require('electron-connect');
+const flowRemoveTypes = require('gulp-flow-remove-types');
 const mainWebpackConfig = require('./source/main/webpack.config');
 const rendererWebpackConfig = require('./source/renderer/webpack.config');
 
@@ -113,6 +114,30 @@ gulp.task('build:renderer:watch', buildRendererWatch());
 
 gulp.task('build', gulp.series('clean:dist', 'build:main', 'build:renderer'));
 
+gulp.task('prepare:themes:utils', () =>
+  gulp
+    .src([
+      'source/renderer/app/themes/utils/checkCreateTheme.js',
+      'source/renderer/app/themes/utils/constants.js',
+      'source/renderer/app/themes/utils/createTheme.js',
+      'source/renderer/app/themes/utils/createShades.js',
+      'source/renderer/app/themes/utils/index.js',
+    ])
+    .pipe(flowRemoveTypes())
+    .pipe(gulp.dest('dist/utils'))
+);
+
+gulp.task('prepare:themes:daedalus', () =>
+  gulp
+    .src([
+      'source/renderer/app/themes/daedalus/cardano.js',
+      'source/renderer/app/themes/daedalus/dark-blue.js',
+      'source/renderer/app/themes/daedalus/light-blue.js',
+    ])
+    .pipe(flowRemoveTypes())
+    .pipe(gulp.dest('dist/daedalus'))
+);
+
 gulp.task(
   'build:watch',
   gulp.series(
@@ -124,6 +149,11 @@ gulp.task(
   )
 );
 
+gulp.task(
+  'build:themes',
+  gulp.series('clean:dist', 'prepare:themes:utils', 'prepare:themes:daedalus')
+);
+
 gulp.task(
   'test:e2e:nodemon',
   shell.task(

package.json

@@ -28,6 +28,7 @@
     "manage:translations": "gulp purge:translations && gulp clear:cache && gulp build && node ./translations/translation-runner.js",
     "storybook": "start-storybook -p 6006 -c storybook",
     "storybook:build": "build-storybook -c storybook -o dist/storybook",
+    "themes:check": "gulp build:themes && node -r esm ./dist/utils/index.js",
     "clear:cache": "gulp clear:cache",
     "nix:dev": "nix-shell --arg autoStartBackend true --arg allowFaultInjection true --arg systemStart",
     "nix:staging": "nix-shell --arg autoStartBackend true --argstr cluster staging"
@@ -61,6 +62,7 @@
     "bufferutil": "4.0.0",
     "cache-loader": "2.0.1",
     "chai": "4.2.0",
+    "chalk": "2.4.2",
     "concurrently": "4.1.0",
     "cross-env": "5.2.0",
     "css-loader": "2.0.1",
@@ -85,9 +87,11 @@
     "eslint-plugin-jsx-a11y": "6.1.2",
     "eslint-plugin-promise": "4.0.1",
     "eslint-plugin-react": "7.11.1",
+    "esm": "3.2.25",
     "faker": "4.1.0",
     "file-loader": "2.0.0",
     "flow-bin": "0.98.1",
+    "gulp-flow-remove-types": "1.0.0",
     "gulp-shell": "0.6.5",
     "hash.js": "1.1.7",
     "html-loader": "0.5.5",

source/main/locales/en-US.json

@@ -2,35 +2,38 @@
   "menu.daedalus": "Daedalus",
   "menu.daedalus.about": "About Daedalus",
   "menu.daedalus.adaRedemption": "Ada Redemption",
-  "menu.daedalus.daedalusDiagnostics": "Daedalus Diagnostics",
-  "menu.daedalus.blockConsolidationStatus": "Block Consolidation Status",
-  "menu.daedalus.quit": "Quit",
+  "menu.daedalus.hideDaedalus": "Hide Daedalus",
+  "menu.daedalus.hideOthers": "Hide Others",
+  "menu.daedalus.showAll": "Show All",
   "menu.daedalus.close": "Close",
+  "menu.daedalus.quit": "Quit",
   "menu.edit": "Edit",
-  "menu.edit.undo": "Undo",
-  "menu.edit.redo": "Redo",
-  "menu.edit.cut": "Cut",
   "menu.edit.copy": "Copy",
+  "menu.edit.cut": "Cut",
   "menu.edit.paste": "Paste",
+  "menu.edit.redo": "Redo",
   "menu.edit.selectAll": "Select All",
-  "menu.helpSupport": "Help and Support",
-  "menu.helpSupport.gpuSafeMode": "GPU Safe Mode",
-  "menu.helpSupport.gpuSafeModeDialogTitle": "Turn off 'GPU safe mode'?",
-  "menu.helpSupport.nonGpuSafeModeDialogTitle": "Turn on 'GPU safe mode'?",
-  "menu.helpSupport.gpuSafeModeDialogMessage": "Turn off 'GPU safe mode'? \n \nYou are about to disable 'GPU safe mode' which will improve the performance of user interface rendering. \n \nClick on 'Yes' to restart Daedalus with 'GPU safe mode' disabled. \n \n If you see a blank screen instead of Daedalus user interface after Daedalus restarts, please turn 'GPU safe mode' back on.",
-  "menu.helpSupport.nonGpuSafeModeDialogMessage": "Turn on 'GPU safe mode'? \n \nYou are about to enable 'GPU safe mode' which will reduce the performance of user interface rendering. \n \nYou should enable this only if you are seeing a blank screen instead of Daedalus user interface. If Daedalus is working properly for you, please click the 'No'. Otherwise, click 'Yes' to restart Daedalus with 'GPU safe mode' enabled.",
+  "menu.edit.undo": "Undo",
+  "menu.helpSupport": "Help",
+  "menu.helpSupport.blockConsolidationStatus": "Block Consolidation Status",
+  "menu.helpSupport.daedalusDiagnostics": "Daedalus Diagnostics",
+  "menu.helpSupport.downloadLogs": "Download Logs",
+  "menu.helpSupport.blankScreenFix": "Blank Screen Fix",
+  "menu.helpSupport.gpuSafeModeDialogCancel": "Cancel",
   "menu.helpSupport.gpuSafeModeDialogConfirm": "Yes",
+  "menu.helpSupport.gpuSafeModeDialogMessage": "Turn off 'Blank screen fix'? \n \nDisabling the blank screen fix setting will improve the performance of user interface rendering by enabling graphics acceleration, however, some users may find that Daedalus runs better with this setting enabled. If you see a blank screen instead of the Daedalus user interface after disabling this setting and restarting Daedalus, please turn this setting back on. \n \nDo you want to disable this setting and restart Daedalus?",
   "menu.helpSupport.gpuSafeModeDialogNo": "No",
-  "menu.helpSupport.gpuSafeModeDialogCancel": "Cancel",
-  "menu.helpSupport.downloadLogs": "Download Logs",
-  "menu.helpSupport.supportRequest": "Support Request",
-  "menu.helpSupport.supportRequestUrl": "https://iohk.zendesk.com/hc/en-us/requests/new/",
+  "menu.helpSupport.gpuSafeModeDialogTitle": "Turn off 'Blank screen fix'?",
   "menu.helpSupport.knownIssues": "Known Issues",
   "menu.helpSupport.knownIssuesUrl": "https://daedaluswallet.io/known-issues/",
+  "menu.helpSupport.nonGpuSafeModeDialogMessage": "Turn on 'Blank screen fix'? \n \nIf the Daedalus user interface is failing to load then enabling this setting may fix the problem. It will reduce the performance of user interface rendering by disabling graphics acceleration, but some users may find that Daedalus runs better with this setting enabled. \n \nEnable this setting only if the Daedalus user interface is failing to load. If Daedalus is working properly, please click ‘No’. Otherwise, click ‘Yes’ to restart Daedalus with the blank screen fix setting enabled. \n \nDo you want to enable this setting and restart Daedalus?",
+  "menu.helpSupport.nonGpuSafeModeDialogTitle": "Turn on 'Blank screen fix'?",
+  "menu.helpSupport.supportRequest": "Support Request",
+  "menu.helpSupport.supportRequestUrl": "https://iohk.zendesk.com/hc/en-us/requests/new/",
   "menu.view": "View",
   "menu.view.reload": "Reload",
+  "menu.view.toggleDeveloperTools": "Toggle Developer Tools",
   "menu.view.toggleFullScreen": "Toggle Full Screen",
   "menu.view.toggleMaximumWindowSize": "Toggle Maximum Window Size",
-  "menu.view.toggleDeveloperTools": "Toggle Developer Tools",
   "window.title.gpuSafeMode": "[GPU Safe Mode]"
 }

source/main/locales/ja-JP.json

@@ -2,35 +2,38 @@
   "menu.daedalus": "Daedalus",
   "menu.daedalus.about": "このDaedalusについて",
   "menu.daedalus.adaRedemption": "Adaの還元",
-  "menu.daedalus.daedalusDiagnostics": "Daedalus診断",
-  "menu.daedalus.blockConsolidationStatus": "ブロック統合状況",
-  "menu.daedalus.quit": "終了",
+  "menu.daedalus.hideDaedalus": "Daedalusを非表示",
+  "menu.daedalus.hideOthers": "他を非表示",
+  "menu.daedalus.showAll": "すべてを表示",
   "menu.daedalus.close": "閉じる",
+  "menu.daedalus.quit": "終了",
   "menu.edit": "編集",
-  "menu.edit.undo": "元に戻す",
-  "menu.edit.redo": "やり直し",
-  "menu.edit.cut": "カット",
   "menu.edit.copy": "コピー",
+  "menu.edit.cut": "カット",
   "menu.edit.paste": "ペースト",
+  "menu.edit.redo": "やり直し",
   "menu.edit.selectAll": "すべて選択",
-  "menu.helpSupport": "ヘルプとサポート",
-  "menu.helpSupport.gpuSafeMode": "GPUセーフモード",
-  "menu.helpSupport.gpuSafeModeDialogTitle": "「GPUセーフモード」を解除しますか？",
-  "menu.helpSupport.nonGpuSafeModeDialogTitle": "「GPUセーフモード」を設定しますか？",
-  "menu.helpSupport.gpuSafeModeDialogMessage": "「GPUセーフモード」を解除しますか？ \n \n「GPUセーフモード」を解除します。ユーザーインターフェイスのレンダリングパフォーマンスが向上します。 \n \n「はい」をクリックしてDaedalusを再起動し、「GPUセーフモード」を解除してください。\n \n Daedalusを再起動した際にDaedalusユーザーインターフェイスの代わりにブランクスクリーンが表示される場合は、「GPUセーフモード」に戻してください。",
-  "menu.helpSupport.nonGpuSafeModeDialogMessage": "「GPUセーフモード」を設定しますか？ \n \n「GPUセーフモード」を設定します。ユーザーインターフェイスのレンダリングパフォーマンスが低下します。 \n \nDaedalusユーザーインターフェイスの代わりにブランクスクリーンが表示される場合にのみ設定してください。Daedalusが通常通りに動作している場合は、「いいえ」をクリックしてください。その他の場合は「はい」をクリックしてDaedalusを再起動し、「GPUセーフモード」を設定してください。",
+  "menu.edit.undo": "元に戻す",
+  "menu.helpSupport": "ヘルプ",
+  "menu.helpSupport.blockConsolidationStatus": "ブロック統合状況",
+  "menu.helpSupport.daedalusDiagnostics": "Daedalus診断",
+  "menu.helpSupport.downloadLogs": "ログのダウンロード",
+  "menu.helpSupport.blankScreenFix": "ブランク画面修正",
+  "menu.helpSupport.gpuSafeModeDialogCancel": "キャンセル",
   "menu.helpSupport.gpuSafeModeDialogConfirm": "はい",
+  "menu.helpSupport.gpuSafeModeDialogMessage": "「ブランク画面修正」を無効にしますか? \n \nブランク画面修正設定を無効にすると、グラフィックアクセラレーションが有効化されてユーザーインターフェイスのレンダリングパフォーマンスが向上しますが、この設定を有効にした方がDaedalusがスムーズに作動する場合があります。この設定を無効にしてDaedalusを再起動した際にDaedalusユーザーインターフェイスの代わりにブランク画面が表示される場合は、この設定をもう一度有効にしてください。 \n \nこの設定を無効にしてDaedalusを再起動しますか。",
   "menu.helpSupport.gpuSafeModeDialogNo": "いいえ",
-  "menu.helpSupport.gpuSafeModeDialogCancel": "キャンセル",
-  "menu.helpSupport.downloadLogs": "ログのダウンロード",
-  "menu.helpSupport.supportRequest": "サポートリクエスト",
-  "menu.helpSupport.supportRequestUrl": "https://iohk.zendesk.com/hc/ja/requests/new/",
+  "menu.helpSupport.gpuSafeModeDialogTitle": "「ブランク画面修正」を無効にしますか?",
   "menu.helpSupport.knownIssues": "既知の問題",
   "menu.helpSupport.knownIssuesUrl": "https://daedaluswallet.io/ja/known-issues/",
+  "menu.helpSupport.nonGpuSafeModeDialogMessage": "「ブランク画面修正」を有効にしますか? \n \nDaedalusユーザーインターフェイスがロードに失敗した際、この設定を有効にすることにより問題が解消される場合があります。この場合、グラフィックアクセラレーションが無効化されることでユーザーインターフェイスのレンダリングパフォーマンスが低下しますが、この設定を有効にした方がDaedalusがスムーズに作動する場合があります。 \n \nこの設定はDaedalusユーザーインターフェイスがロードに失敗した場合にのみ有効にしてください。Daedalusが正常に作動している場合は[いいえ]をクリックします。正常に作動していない場合には[はい]をクリックし、ブランク画面修正設定を有効にしてDaedalusを再起動してください。 \n \nこの設定を有効にしてDaedalusを再起動しますか。",
+  "menu.helpSupport.nonGpuSafeModeDialogTitle": "「ブランク画面修正」を有効にしますか?",
+  "menu.helpSupport.supportRequest": "サポートリクエスト",
+  "menu.helpSupport.supportRequestUrl": "https://iohk.zendesk.com/hc/ja/requests/new/",
   "menu.view": "見る",
   "menu.view.reload": "リロード",
+  "menu.view.toggleDeveloperTools": "「開発者ツールの切り替え」",
   "menu.view.toggleFullScreen": "フルスクリーン切り替え",
   "menu.view.toggleMaximumWindowSize": "最大ウインドウサイズ切り切り替え",
-  "menu.view.toggleDeveloperTools": "「開発者ツールの切り替え」",
   "window.title.gpuSafeMode": "[GPUセーフモード]"
 }

source/main/menus/osx.js

@@ -18,6 +18,7 @@ export const osxMenu = (
   actions: MenuActions,
   translations: {},
   supportRequestData: SupportRequests,
+  isNodeInSync: boolean,
   translation: Function = getTranslation(translations, id)
 ) => [
   {
@@ -31,24 +32,25 @@ export const osxMenu = (
       },
       {
         label: translation('daedalus.adaRedemption'),
+        enabled: isNodeInSync,
         click() {
           actions.openAdaRedemptionScreen();
         },
       },
+      { type: 'separator' },
       {
-        label: translation('daedalus.blockConsolidationStatus'),
-        accelerator: 'Command+B',
-        click() {
-          actions.openBlockConsolidationStatusDialog();
-        },
+        label: translation('daedalus.hideDaedalus'),
+        role: 'hide',
       },
       {
-        label: translation('daedalus.daedalusDiagnostics'),
-        accelerator: 'Command+D',
-        click() {
-          actions.openDaedalusDiagnosticsDialog();
-        },
+        label: translation('daedalus.hideOthers'),
+        role: 'hideothers',
       },
+      {
+        label: translation('daedalus.showAll'),
+        role: 'unhide',
+      },
+      { type: 'separator' },
       {
         label: translation('daedalus.quit'),
         accelerator: 'Command+Q',
@@ -71,9 +73,7 @@ export const osxMenu = (
         accelerator: 'Shift+Command+Z',
         role: 'redo',
       },
-      {
-        type: 'separator',
-      },
+      { type: 'separator' },
       {
         label: translation('edit.cut'),
         accelerator: 'Command+X',
@@ -120,7 +120,14 @@ export const osxMenu = (
     label: translation('helpSupport'),
     submenu: compact([
       {
-        label: translation('helpSupport.gpuSafeMode'),
+        label: translation('helpSupport.knownIssues'),
+        click() {
+          const faqLink = translation('helpSupport.knownIssuesUrl');
+          shell.openExternal(faqLink);
+        },
+      },
+      {
+        label: translation('helpSupport.blankScreenFix'),
         type: 'checkbox',
         checked: isInSafeMode,
         click(item) {
@@ -152,12 +159,7 @@ export const osxMenu = (
           });
         },
       },
-      {
-        label: translation('helpSupport.downloadLogs'),
-        click() {
-          showUiPartChannel.send(NOTIFICATIONS.DOWNLOAD_LOGS, window);
-        },
-      },
+      { type: 'separator' },
       {
         label: translation('helpSupport.supportRequest'),
         click() {
@@ -176,10 +178,24 @@ export const osxMenu = (
         },
       },
       {
-        label: translation('helpSupport.knownIssues'),
+        label: translation('helpSupport.downloadLogs'),
         click() {
-          const faqLink = translation('helpSupport.knownIssuesUrl');
-          shell.openExternal(faqLink);
+          showUiPartChannel.send(NOTIFICATIONS.DOWNLOAD_LOGS, window);
+        },
+      },
+      { type: 'separator' },
+      {
+        label: translation('helpSupport.blockConsolidationStatus'),
+        accelerator: 'Command+B',
+        click() {
+          actions.openBlockConsolidationStatusDialog();
+        },
+      },
+      {
+        label: translation('helpSupport.daedalusDiagnostics'),
+        accelerator: 'Command+D',
+        click() {
+          actions.openDaedalusDiagnosticsDialog();
         },
       },
     ]),