Skip to content

Commit

Permalink
Merge pull request #3126 from input-output-hk/chore/ddw-1221-fix-chro…
Browse files Browse the repository at this point in the history
…matic

[DDW-1221] Remove Chromatic from project
  • Loading branch information
Marcin Mazurek committed Jun 13, 2023
2 parents ffaace8 + 619cd98 commit aa05372
Show file tree
Hide file tree
Showing 7 changed files with 5 additions and 51 deletions.
1 change: 0 additions & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ Open a thread on #daedalus-qa on Slack, mention `@daedalusqa` and `@daedalusteam
- [ ] PR assigned to the PR author(s)
- [ ] `input-output-hk/daedalus-dev` and `input-output-hk/daedalus-qa` assigned as PR reviewers
- [ ] If there are UI changes, Alexander Rukin assigned as an additional reviewer
- [ ] All visual regression testing has been reviewed (assign `run Chromatic` label to PR to trigger the run)
- [ ] PR has appropriate labels (`release-vNext`, `feature`/`bug`/`chore`, `WIP`)
- [ ] PR link is added to a Jira ticket, ticket moved to In Review
- [ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
Expand Down
39 changes: 0 additions & 39 deletions .github/workflows/chromatic.yml

This file was deleted.

1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

### Chores

- Removed Chromatic from project ([PR 3126](https://github.com/input-output-hk/daedalus/pull/3126))
- Upgraded Electron to 24.2, and Node.js to 18.× ([PR 3124](https://github.com/input-output-hk/daedalus/pull/3124))
- Defined a proxy for currency conversions ([PR 3121](https://github.com/input-output-hk/daedalus/pull/3121))
- Switched Daedalus to be built with Nix flakes ([PR 3008](https://github.com/input-output-hk/daedalus/pull/3008))
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
"i18n:manage": "yarn i18n:extract && yarn i18n:check",
"storybook": "start-storybook -p 6006 -c storybook --ci /",
"storybook:build": "build-storybook -c storybook -o dist/storybook",
"storybook:build:chromatic": "build-storybook -c storybook",
"themes:check:createTheme": "gulp build:themes && yarn node-swc ./dist/scripts/check.js",
"themes:update": "gulp build:themes && yarn node-swc ./dist/scripts/update.js && yarn prettier --loglevel warn --write source/renderer/app/themes/daedalus/*.ts",
"themes:copy": "yarn node-swc source/renderer/app/themes/utils/copyTheme.ts && yarn prettier --loglevel warn --write source/renderer/app/themes/daedalus/*.ts",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export default class LogosDisplay extends Component<Props> {
return (
<div className={styles.component}>
<SVGInline svg={adaLogo} className={currencyLogoStyles} />
<div className={daedalusLogoStyles} data-chromatic="ignore">
<div className={daedalusLogoStyles}>
<Lottie options={logoAnimationOptionsLottie} />
</div>
<SVGInline svg={cardanoLogo} className={apiLogoStyles} />
Expand Down
9 changes: 0 additions & 9 deletions storybook/monkeyPatchDateTime.ts

This file was deleted.

3 changes: 3 additions & 0 deletions storybook/stories/settings/general/General.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ const getParamName = (obj, itemName): any =>
Object.entries(obj).find((entry: [any, any]) => itemName === entry[1]);

/* eslint-disable consistent-return */
// @ts-ignore
// @ts-ignore
storiesOf('Settings / General', module)
.addDecorator(SettingsWrapper) // ====== Stories ======
.add(
Expand Down Expand Up @@ -99,6 +101,7 @@ storiesOf('Settings / General', module)
}}
/>
))
// @ts-ignore ts-migrate(2345)
.add('Terms of Service', (_, props) => {
const termsOfUseSource = require(`../../../../source/renderer/app/i18n/locales/terms-of-use/${props.locale}.md`);

Expand Down

0 comments on commit aa05372

Please sign in to comment.