Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-504] Daedalus start with time offset to the past #1194

Conversation

nikolaglumac
Copy link
Contributor

@nikolaglumac nikolaglumac commented Nov 23, 2018

This PR fixes an issue where NTP error screen would not be shown in case Daedalus was started with time offset to the past. In this case Daedalus was stuck at "Connecting to network..." screen without any notification that the time is off. This is now fixed and Daedalus shows the NTP error screen.


Review Checklist:

Basics

  • PR is updated to the most recent version of target branch (and there are no conflicts)
  • PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub
  • Automated tests: All acceptance tests are passing (yarn run test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn run dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn run package / CI builds)
  • There are no flow errors or warnings (yarn run flow:test)
  • There are no lint errors or warnings (yarn run lint)
  • Text changes are proofread and approved (Jane Wild)
  • There are no missing translations (running yarn run manage:translations produces no changes)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn run storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly documented and commented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-rendering
  • Any code that only works in Electron is neatly separated from components

Testing

  • New feature / change is covered by acceptance tests
  • All existing acceptance tests are still up-to-date
  • New feature / change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review:

  • Merge PR
  • Delete source branch
  • Move ticket to done on the Youtrack board

@nikolaglumac
Copy link
Contributor Author

@amias-iohk @DominikGuzei I have tested OSX installer and it is working as expected.
Test steps include:

  1. Running Daedalus while time is in sync with NTP
  2. Switching time to the past by 2 mins - upon which Daedalus shows red NTP error screen
  3. Shutting down Daedalus while time is still offset to the past
  4. Starting Daedalus while time is still offset to the past
  5. Daedalus shows red NTP error screen
  6. Switching time to match NTP time
  7. Daedalus switches to blue "Connecting to network..." screen and eventually connects

@DominikGuzei DominikGuzei merged commit 95cce45 into release/0.12.0 Nov 26, 2018
@nikolaglumac nikolaglumac deleted the fix/ddw-504-daedalus-start-with-time-offset-to-the-past branch November 26, 2018 10:37
@nikolaglumac nikolaglumac mentioned this pull request Nov 26, 2018
Copy link

@DmitriiGaico DmitriiGaico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and Approved by QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants