[DDW-675] Fix broken Storybook #1402
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
| import os from 'os'; | ||
| import { uniq, upperFirst, get, includes } from 'lodash'; | ||
| import { version } from '../../package.json'; | ||
| // import { stateDirectoryPath } from './config'; | ||
| import type { Environment } from '../common/types/environment.types'; | ||
| import { | ||
| DEVELOPMENT, | ||
|
|
@@ -82,7 +82,7 @@ export const environment: Environment = Object.assign( | |
| isWindows, | ||
| isMacOS, | ||
| isLinux, | ||
| stateDirectoryPath: '', | ||
|
There was a problem hiding this comment. @DeeJayElly I have on purpose used an empty string for the value of state directory. It should be fixed in the scope of this task: https://iohk.myjetbrains.com/youtrack/issue/DDW-676 There was a problem hiding this comment. The |
||
| isInSafeMode, | ||
| }, | ||
| process.env | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DeeJayElly we can not use anything from
./configas this breaks the storybook.The problem is that within
./configwe usefsto load theLauncherConfigwhich contains all the paths we need (incl. the state path).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This import should be removed and we should send the state path to the renderer process through the IPC channel. Similar to how we do for the system locale: https://github.com/input-output-hk/daedalus/blob/develop/source/main/index.js#L142
Network status store should receive this value on app start time and then propagate it to the Network status container and component.